Commit Graph

644 Commits

Author SHA1 Message Date
florian.berthold 0b0a5004eb fix: pcall GetSpecInfoByID, fix specs_per_class indexing, FDID->string
Three CoA 3.3.5 compatibility fixes for Details:

1. LibOpenRaid/LibOpenRaid.lua:1298 - C_ClassInfo.GetSpecInfoByID is now
   pcall-guarded. On CoA, specId can be non-numeric and the API errors
   out, taking the unit-info update with it. Matches the pcall pattern
   already shipped for GetSpecInfo(class, spec) in 7 sibling files.

2. Libs/DF/fw.lua:4257 - specs_per_class[index] was writing into the
   outer table by numeric index, clobbering keys and never populating
   the nested per-class table initialised on line 4253. Corrected to
   specs_per_class[class][index] so DF:GetClassSpecIDs(engClass) returns
   the right list.

3. Libs/DF/icongeneric.lua:211 - SetTexture(130759) passed a FileDataID
   to a 3.3.5 client that only resolves string paths, leaving icon
   borders blank. Replaced with the documented mapping
   [[Interface\COMMON\WhiteIconFrame]] (same path already used in
   frames/window_mythicplus/window_end_of_run.lua:358). Follows the
   FDID->string pattern shipped in coa-ace3 d422ad3.
2026-05-24 17:38:31 +02:00
florian.berthold 02b17e0a00 fix: pcall-guard C_ClassInfo.GetSpecInfo to silence CoA spec API spam
On the current CoA Beta client, C_ClassInfo.GetAllSpecs(class) returns
items that GetSpecInfo cannot accept as arg #2, throwing
'Script::ValidateInput Invalid argument type at index 2. Expected string.'
~150 times per session across DF, LibOpenRaid, gears, profiles, etc.

Wrap every unguarded GetSpecInfo(class, spec) site in pcall + nil-guard
so the iteration skips bad entries silently. Matches the pattern already
used by CoaExporter and prevents Error.txt flooding.
2026-05-23 00:14:25 +02:00
Tercio Jose defce45d74 Changing player detection by GUID 2024-09-04 19:03:50 -07:00
Tercio Jose f392108ea2 Libraries Updates, Quick fixes, Version bump for wow 11 launch 2024-08-26 10:22:30 -07:00
Tercio Jose d10c2083c5 Open Raid update 2024-08-26 10:19:07 -07:00
Tercio Jose 97e83c95e3 Several bug fixes, visual updates on m+ panel, fixed m+ chart again, more updates for Breakdown Wndow 2024-08-26 10:12:18 -07:00
Tercio Jose c4793587f7 More visual changes for wow 11 2024-08-26 10:09:54 -07:00
Tercio Jose 214f0b2d88 Libraries update 2024-08-26 10:06:39 -07:00
Tercio Jose 16fd6de6f9 Fixed an issue with the end of m+ panel 2024-08-26 10:05:52 -07:00
Tercio Jose 4032ea3746 Added new file to framework 'packtable' 2024-08-26 10:05:34 -07:00
Tercio Jose 065c61c8ff Major rework on the M+ end of run panel 2024-08-26 10:05:12 -07:00
Tercio Jose c8dc780082 Complete re-write for the mythic+ chart shown in the end of the run 2024-08-26 09:47:38 -07:00
Tercio Jose 30af843b42 Pushing release for Flamanis fixes on for classic pet, av and other bugs. 2024-08-26 09:35:02 -07:00
Tercio Jose 68be90f6cd Fixing typos and updating OpenRaid 2024-08-26 09:33:48 -07:00
Tercio Jose a65839529b Fixed an issue with the loot on the end of the mythic plus panel 2024-08-26 09:28:41 -07:00
Tercio Jose 534a39ced5 Framework Update 2024-08-26 09:26:17 -07:00
Tercio Jose 4c65968927 Fixed /key not showing the map name 2024-08-26 09:25:47 -07:00
Tercio Jose beca97a948 Changed the health on death logs to be live percent (health % at hit moment), was before health amount divided by default character life amount 2024-08-26 09:24:39 -07:00
Tercio Jose 41a347e606 Updating LibOpenRaid 2024-08-26 09:23:33 -07:00
Tercio Jose c405c2be75 Library update and release version 2024-08-26 09:22:32 -07:00
Tercio Jose 4409149841 show "one hour buffs" if they aren't 100% uptime. 2024-08-26 09:13:55 -07:00
Tercio Jose 1bf24647ec Framework update, added RaidTargets in the unitId cache, class_utility code cleanup 2024-08-26 09:00:21 -07:00
Tercio Jose 7538b36b2a Added more tools to debug pets on '/details debug' and '/details mypets' 2024-08-26 08:48:01 -07:00
Tercio Jose f7c52f821e More fixes 2024-08-26 08:45:30 -07:00
andrew6180 d854e19caa Fix get player info 2024-07-13 11:00:06 -07:00
Tercio Jose 904a7eab1b framework update 2024-07-10 16:12:25 -07:00
Tercio Jose 4116ae29e2 Removed some debug msgs, added /de m+debug and /de m+debugloot; Framework update 2024-07-09 07:04:39 -07:00
Tercio Jose f6c59381ab Pet container rewritten 2024-07-09 06:55:49 -07:00
Tercio Jose 85fff228df Framework update 2024-06-18 13:09:01 -07:00
andrew6180 016c68d243 classless/reborn cooldowns for paladin and warrior 2024-06-12 01:45:27 -07:00
andrew6180 f5ebc96d13 Reborn interrupts 2024-06-12 00:46:10 -07:00
andrew6180 e7af2f029c Add reborn spec guesses. Make sure every spec has some spells 2024-06-12 00:36:04 -07:00
andrew6180 a1296ea54a Add Mind Flay to spec spells 2024-06-11 23:30:54 -07:00
andrew6180 eac2b9ae10 Port over spec spell list from old details backport 2024-06-11 22:31:14 -07:00
andrew6180 5cfcf02d31 (EMPTY) move spec spells / class spells to LibOpenRaid 2024-06-11 22:07:21 -07:00
andrew6180 171731f3db Use LibOpenRaid ThingsToMaintain for DF Cooldowns 2024-06-11 21:21:39 -07:00
andrew6180 95da7ef86f Healing potions & interrupts 2024-06-11 09:12:43 -07:00
andrew6180 05b86d973c All ascension food is tier 1 2024-06-11 08:21:54 -07:00
andrew6180 84364bbe13 All ascension flasks are tier 1 2024-06-11 08:21:21 -07:00
andrew6180 5990323b98 Fix IsXWoW 2024-06-10 11:38:50 -07:00
andrew6180 1a4a06d101 Merge remote-tracking branch 'fork/master' 2024-06-10 08:55:07 -07:00
Tercio Jose 5bf4d2e220 Warlock fixes for tww 2024-06-09 21:44:24 -03:00
Tercio Jose ccb20e4ecc Fixed GetItemInfo for the m+ end of dungeon 2024-06-09 16:17:06 -03:00
Flamanis 129c77a9d9 Fix GetOverrideSpell for TWW 2024-06-09 03:55:56 -05:00
Flamanis 3c1c183f88 Add exist check for definition id 2024-06-08 19:15:55 -05:00
Tercio Jose 9c56fa3376 Fixing an issue with the loot display at the End of Mythic Plus panel 2024-06-08 19:41:10 -03:00
Tercio Jose ee2e69e378 Updated wow api definitions to include C_UnitAuras into the luaserver 2024-06-08 15:26:53 -03:00
Tercio Jose da686c7615 LibOpenRaid for v11 by Krealle 2024-06-07 19:29:07 -03:00
Tercio Jose 036b5d9a86 Merge pull request #741 from Flamanis/TWW-Fixes
Initial changes to fix TWW issues
2024-06-07 19:18:29 -03:00
Tercio Jose 68e15ac7ca Change logs, Framework Update 2024-06-07 11:07:24 -03:00