Commit Graph

2493 Commits

Author SHA1 Message Date
florian.berthold 5bb7be4968 chore: hoist plugins to root and move main into Details/
Each Details_* plugin and the main Details addon now lives in its own
repo-root folder, matching the Exiles fork-layout convention.
2026-05-25 10:59:28 +02:00
florian.berthold 0b0a5004eb fix: pcall GetSpecInfoByID, fix specs_per_class indexing, FDID->string
Three CoA 3.3.5 compatibility fixes for Details:

1. LibOpenRaid/LibOpenRaid.lua:1298 - C_ClassInfo.GetSpecInfoByID is now
   pcall-guarded. On CoA, specId can be non-numeric and the API errors
   out, taking the unit-info update with it. Matches the pcall pattern
   already shipped for GetSpecInfo(class, spec) in 7 sibling files.

2. Libs/DF/fw.lua:4257 - specs_per_class[index] was writing into the
   outer table by numeric index, clobbering keys and never populating
   the nested per-class table initialised on line 4253. Corrected to
   specs_per_class[class][index] so DF:GetClassSpecIDs(engClass) returns
   the right list.

3. Libs/DF/icongeneric.lua:211 - SetTexture(130759) passed a FileDataID
   to a 3.3.5 client that only resolves string paths, leaving icon
   borders blank. Replaced with the documented mapping
   [[Interface\COMMON\WhiteIconFrame]] (same path already used in
   frames/window_mythicplus/window_end_of_run.lua:358). Follows the
   FDID->string pattern shipped in coa-ace3 d422ad3.
2026-05-24 17:38:31 +02:00
florian.berthold 02b17e0a00 fix: pcall-guard C_ClassInfo.GetSpecInfo to silence CoA spec API spam
On the current CoA Beta client, C_ClassInfo.GetAllSpecs(class) returns
items that GetSpecInfo cannot accept as arg #2, throwing
'Script::ValidateInput Invalid argument type at index 2. Expected string.'
~150 times per session across DF, LibOpenRaid, gears, profiles, etc.

Wrap every unguarded GetSpecInfo(class, spec) site in pcall + nil-guard
so the iteration skips bad entries silently. Matches the pattern already
used by CoaExporter and prevents Error.txt flooding.
2026-05-23 00:14:25 +02:00
florian.berthold 9c204f6763 ci: preserve upstream line endings (CRLF) for clean upstream diffs 2026-05-08 04:01:33 +02:00
andrew6180 af040852a6 fix but this shouldnt ever happen without someone breaking their ldb pretty sure 2026-01-02 12:46:50 -07:00
andrew6180 2c78489881 check damageTakenArray first 2025-12-04 15:21:53 -07:00
andrew6180 daca3912b9 missing math_max local 2025-10-31 12:14:02 -07:00
andrew6180 aa6220c2fe reborn fire ele / earth ele 2025-10-11 22:17:24 -07:00
andrew6180 10aa661796 Fix lua error for char advancement upgrade 2025-08-05 10:48:28 -07:00
andrew6180 10347c7465 new possible fix for absorb order sorting. Bump Version. 2024-12-09 12:22:55 -07:00
andrew6180 3dfc122946 change implementation of extra attacks to 'details' way 2024-12-09 12:08:52 -07:00
Andrew 1b6370da04 Merge pull request #2 from kiriaziskokkinos/master
Add support for seperation of Extra Attack effects
2024-12-09 12:02:09 -07:00
Kyriazis Kokkinos eaafbfa5dd Add support for seperation of Extra Attack effects 2024-12-09 16:31:31 +02:00
andrew6180 96a35837df Fix lua error from leaving an active run maybe? 2024-11-19 13:42:29 -07:00
andrew6180 03f73d50e5 bump version 2024-11-15 17:39:58 -07:00
andrew6180 7b91e6e06f MythicDungeons: Disable mythic dungeon end panel 2024-11-15 17:37:40 -07:00
andrew6180 160db8e22a maybe fix sort error 2024-11-15 17:33:24 -07:00
andrew6180 fce4ad8e4b bump version 2024-11-05 17:36:41 -07:00
andrew6180 dc84e8e364 mythicdungeon: fix lua error 2024-11-05 17:36:36 -07:00
andrew6180 a034ddfa3e Parser: track absorbs from absorbed amount on spell_dmg 2024-11-05 17:33:16 -07:00
andrew6180 85c6a18fd0 bump version 2024-10-18 13:13:39 -07:00
Tercio Jose 60178963eb Disabled the open world parser for now 2024-10-18 13:11:46 -07:00
andrew6180 6480fbb303 Possible fix for table.sort having nil values? 2024-10-18 11:39:48 -07:00
andrew6180 c1ede02c8a increment version 2024-10-07 11:21:41 -07:00
andrew6180 402b918045 Parser: fix energize events. Remove energize overflow since its not tracked in 3.3.5 2024-10-07 11:18:13 -07:00
andrew6180 f82040a99f Kinda temporary handler for spell school absorbs. May cause side issues but should have school specific total absorb eventually. 2024-09-08 11:44:49 -07:00
andrew6180 14f904a832 Do not -1 GetNumGroupMembers, party UnitIdCache includes player. 2024-09-08 11:06:34 -07:00
andrew6180 f15230096d Remove mask texture 2024-09-06 13:46:54 -07:00
andrew6180 1431681412 Remove dragonflight checks 2024-09-06 11:39:12 -07:00
andrew6180 ec97cb3906 Fix bad aurainfo 2024-09-06 03:19:32 -07:00
andrew6180 e89876a473 Locale: Missing locale strings 2024-09-05 07:42:42 -07:00
andrew6180 1c349f8086 change news to ascension release date 2024-09-05 07:33:47 -07:00
Tercio Jose 7442336f74 Lazy load options panel 2024-09-04 19:04:29 -07:00
Tercio Jose defce45d74 Changing player detection by GUID 2024-09-04 19:03:50 -07:00
Tercio Jose fe8b3536d1 Removed the name cache from Parser 2024-09-04 18:59:22 -07:00
andrew6180 449b45154a Check ignore parent alpha exists 2024-08-26 10:47:17 -07:00
andrew6180 c5333db47b Fix misc lua errors from cherry-picking 2024-08-26 10:45:07 -07:00
Tercio Jose f392108ea2 Libraries Updates, Quick fixes, Version bump for wow 11 launch 2024-08-26 10:22:30 -07:00
Tercio Jose cec32b8d17 Fixed custom display My Spells not using spell school color and tooltip being to small 2024-08-26 10:20:58 -07:00
Tercio Jose 5e5f24d218 Duspels 2024-08-26 10:20:49 -07:00
Tercio Jose 95096af849 Fixed Streamer plugin bug 2024-08-26 10:20:22 -07:00
Tercio Jose d10c2083c5 Open Raid update 2024-08-26 10:19:07 -07:00
Tercio Jose a1b78cf9bd Removed deprecated code and fixes 2024-08-26 10:19:02 -07:00
Tercio Jose 3e7a7fe162 Fixed scripts not using new spell info API 2024-08-26 10:17:49 -07:00
Tercio Jose 0897550b1b Fixed an issue with player names cache getting 'Unknown' from UnitName() 2024-08-26 10:17:31 -07:00
Tercio Jose 11a821729b removed debug prints 2024-08-26 10:15:19 -07:00
Tercio Jose f94e0d2b76 a few fixes 2024-08-26 10:14:54 -07:00
Tercio Jose 38f60d6cd6 version up 2024-08-26 10:14:48 -07:00
Tercio Jose ff80c8c9c6 Fixing last commit stuff 2024-08-26 10:14:43 -07:00
Tercio Jose 6456547ab1 Fixing battleground naming bug, fixed tooltip border 2024-08-26 10:13:54 -07:00