Commit Graph

173 Commits

Author SHA1 Message Date
florian.berthold 0b0a5004eb fix: pcall GetSpecInfoByID, fix specs_per_class indexing, FDID->string
Three CoA 3.3.5 compatibility fixes for Details:

1. LibOpenRaid/LibOpenRaid.lua:1298 - C_ClassInfo.GetSpecInfoByID is now
   pcall-guarded. On CoA, specId can be non-numeric and the API errors
   out, taking the unit-info update with it. Matches the pcall pattern
   already shipped for GetSpecInfo(class, spec) in 7 sibling files.

2. Libs/DF/fw.lua:4257 - specs_per_class[index] was writing into the
   outer table by numeric index, clobbering keys and never populating
   the nested per-class table initialised on line 4253. Corrected to
   specs_per_class[class][index] so DF:GetClassSpecIDs(engClass) returns
   the right list.

3. Libs/DF/icongeneric.lua:211 - SetTexture(130759) passed a FileDataID
   to a 3.3.5 client that only resolves string paths, leaving icon
   borders blank. Replaced with the documented mapping
   [[Interface\COMMON\WhiteIconFrame]] (same path already used in
   frames/window_mythicplus/window_end_of_run.lua:358). Follows the
   FDID->string pattern shipped in coa-ace3 d422ad3.
2026-05-24 17:38:31 +02:00
florian.berthold 02b17e0a00 fix: pcall-guard C_ClassInfo.GetSpecInfo to silence CoA spec API spam
On the current CoA Beta client, C_ClassInfo.GetAllSpecs(class) returns
items that GetSpecInfo cannot accept as arg #2, throwing
'Script::ValidateInput Invalid argument type at index 2. Expected string.'
~150 times per session across DF, LibOpenRaid, gears, profiles, etc.

Wrap every unguarded GetSpecInfo(class, spec) site in pcall + nil-guard
so the iteration skips bad entries silently. Matches the pattern already
used by CoaExporter and prevents Error.txt flooding.
2026-05-23 00:14:25 +02:00
Tercio Jose f392108ea2 Libraries Updates, Quick fixes, Version bump for wow 11 launch 2024-08-26 10:22:30 -07:00
Tercio Jose d10c2083c5 Open Raid update 2024-08-26 10:19:07 -07:00
Tercio Jose 214f0b2d88 Libraries update 2024-08-26 10:06:39 -07:00
Tercio Jose 065c61c8ff Major rework on the M+ end of run panel 2024-08-26 10:05:12 -07:00
Tercio Jose 68be90f6cd Fixing typos and updating OpenRaid 2024-08-26 09:33:48 -07:00
Tercio Jose 4c65968927 Fixed /key not showing the map name 2024-08-26 09:25:47 -07:00
Tercio Jose beca97a948 Changed the health on death logs to be live percent (health % at hit moment), was before health amount divided by default character life amount 2024-08-26 09:24:39 -07:00
Tercio Jose 41a347e606 Updating LibOpenRaid 2024-08-26 09:23:33 -07:00
Tercio Jose c405c2be75 Library update and release version 2024-08-26 09:22:32 -07:00
andrew6180 d854e19caa Fix get player info 2024-07-13 11:00:06 -07:00
Tercio Jose f6c59381ab Pet container rewritten 2024-07-09 06:55:49 -07:00
andrew6180 016c68d243 classless/reborn cooldowns for paladin and warrior 2024-06-12 01:45:27 -07:00
andrew6180 f5ebc96d13 Reborn interrupts 2024-06-12 00:46:10 -07:00
andrew6180 e7af2f029c Add reborn spec guesses. Make sure every spec has some spells 2024-06-12 00:36:04 -07:00
andrew6180 a1296ea54a Add Mind Flay to spec spells 2024-06-11 23:30:54 -07:00
andrew6180 eac2b9ae10 Port over spec spell list from old details backport 2024-06-11 22:31:14 -07:00
andrew6180 5cfcf02d31 (EMPTY) move spec spells / class spells to LibOpenRaid 2024-06-11 22:07:21 -07:00
andrew6180 171731f3db Use LibOpenRaid ThingsToMaintain for DF Cooldowns 2024-06-11 21:21:39 -07:00
andrew6180 95da7ef86f Healing potions & interrupts 2024-06-11 09:12:43 -07:00
andrew6180 05b86d973c All ascension food is tier 1 2024-06-11 08:21:54 -07:00
andrew6180 84364bbe13 All ascension flasks are tier 1 2024-06-11 08:21:21 -07:00
andrew6180 1a4a06d101 Merge remote-tracking branch 'fork/master' 2024-06-10 08:55:07 -07:00
Flamanis 129c77a9d9 Fix GetOverrideSpell for TWW 2024-06-09 03:55:56 -05:00
Flamanis 3c1c183f88 Add exist check for definition id 2024-06-08 19:15:55 -05:00
Tercio Jose da686c7615 LibOpenRaid for v11 by Krealle 2024-06-07 19:29:07 -03:00
Flamanis 510867a469 imit 2024-06-06 06:34:41 -05:00
andrew6180 6a677e5a22 fix lua errors 2024-05-27 01:48:01 -07:00
andrew6180 2368623870 fix bad class icon 2024-05-26 20:04:08 -07:00
andrew6180 b6264af117 fix lua error 2024-05-26 17:00:59 -07:00
andrew6180 0756c77923 update default unit prototype 2024-05-26 16:47:37 -07:00
andrew6180 00d1d99c51 update openraid docs 2024-05-26 16:46:21 -07:00
andrew6180 eb16000a12 Send mystic enchant through OpenRaidLib renown 2024-05-26 16:45:48 -07:00
andrew6180 9147d275e0 Fix small lua errors 2024-05-24 15:21:51 -07:00
andrew6180 a424407542 RaidCheck: should be working just no data filled out in LibOpenRaid 2024-05-23 11:18:34 -07:00
andrew6180 c768231956 Ascension has GROUP_ROSTER_UPDATE actually 2024-05-21 15:42:52 -07:00
andrew6180 c89fc78cec Cleanup GetBuildInfo since we dont need to check versions. 2024-05-21 02:06:53 -07:00
andrew6180 90a085acf0 Clean up most modern GUID usage. 2024-05-20 13:13:52 -07:00
andrew6180 63caa6089f Remove keystone itemid (unused) 2024-05-18 09:14:50 -07:00
andrew6180 bb7e0d2c27 Work on Ascension Backport 2024-05-17 15:08:08 -07:00
Flamanis 3e1212a7ec Cata fixes. 2024-04-20 10:15:23 -05:00
Tercio Jose 675d4f000d Added Void Tendril's Grasp as a crowd control debuff 2024-04-16 13:00:17 -03:00
Tercio Jose 9e8a5a3a06 Version Update 2024-04-05 17:58:37 -03:00
Flamanis cd4a2c72b4 Initial changes to try to fix cata beta. 2024-03-17 04:28:51 -05:00
Tercio Jose 2928593144 Updated Open Raid Library 2024-02-05 20:05:58 -03:00
Tercio Jose c1d8082546 Using now a crowd control spell list from Lib Open Raid 2024-02-05 19:57:19 -03:00
Tercio Jose ee0b350aba Maintenance Update and Mythic Dungeon Plus development progress
- Dungeon followers now correctly show into the damage done section.
- Fixed an error while statusbar plugin options.
- Framework update.
- Mythic Dungeon Plus code has been separated into six files (was just 2), this will help with the organization
and maintenance of the code.
2024-01-31 13:34:00 -03:00
Tercio Jose b7c2b6c7a1 Release Candidate 1 2024-01-20 14:28:25 -03:00
Tercio Jose 4eff7b223e General Fixes after major patch 2024-01-17 11:35:18 -03:00