Exiles/coa-omen
4
0
Fork 0
Code Pull Requests Actions Packages Releases 2 Wiki Activity

Localize strings, correct grammar and spelling, fix close menu error, add hide omen menu item.

Browse Source
This commit is contained in:
Xinhuan
2008-10-13 21:29:11 +08:00
parent 70336d726c
commit 30d5b7cdaa
2 changed files with 31 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Localization/enUS.lua
+17 -9
View File
@@ -5,10 +5,12 @@ if not L then return end
-- Main Omen window
L["<Unknown>"] = true
L["Test Mode"] = true
L["Omen Quick Menu"] = true
L["Enter Test Mode"] = true
L["Exit Test Mode"] = true
L["Unlock Omen"] = true
L["Open Config"] = true
L["Hide Omen"] = true
L["Name"] = true
L["Threat [%]"] = true
L["TPS"] = true
@@ -135,6 +137,12 @@ L["Open the configuration dialog"] = true
-- Config strings, warning settings section
L["Warning Settings"] = true
L["OMEN_WARNINGS_DESC"] = "This section allows you to customize when and how Omen notifies you if you are about to pull aggro."
L["Enable Sound"] = true
L["Causes Omen to play a chosen sound effect"] = true
L["Enable Screen Flash"] = true
L["Causes the entire screen to flash red momentarily"] = true
L["Enable Screen Shake"] = true
L["Causes the entire game world to shake momentarily. This option only works if nameplates are turned off."] = true
L["Enable Warning Message"] = true
L["Print a message to screen when you accumulate too much threat"] = true
L["Warning Threshold %"] = true
@@ -165,27 +173,27 @@ L["Warrior"] = true
L["GENERAL_FAQ"] = [[
|cffffd200How is Omen3 different from Omen2?|r
Omen3 relies completely on the Blizzard threat API and threat events and does not attempt to calculate or extrapolate threat unlike in Omen2.
Omen3 relies completely on the Blizzard threat API and threat events. It does not attempt to calculate or extrapolate threat unlike Omen2.
Omen2 used what we called the Threat-2.0 library, which was responsible for monitoring the combat log and your spellcasting for action you do, checking your buffs, debuffs, stances, talents and your gear for threat modifiers and then calculating your threat based on what was known or guessed from observed threat behavior. Stuff like knockbacks reducing tank aggro was just guessed (we assumed them to be mostly 50% reduction) but impossible to confirm.
Omen2 used what we called the Threat-2.0 library. This library was responsible for monitoring the combat log, spellcasting, buffs, debuffs, stances, talents and gear modifiers for calculating each individuals threat. Threat was calculated based on what was known or approximated from observed behaviors. Many abilities such as knockbacks were just assumed (to be a 50% threat reduction) as they were mostly impossible to confirm.
Threat-2.0 then used the addon communication channel to transmit what it thought was your threat to the rest of the raid and Omen2 used this information for display.
The Threat-2.0 library also included addon communication to broadcast your threat to the rest of the raid as long as they were also using Threat-2.0. This data was then used to provide a raid wide display of threat information.
Now Omen3 does none of these, it just shows exactly what Blizzard says everyone's threat is on mobX, there is no syncing, no combat log parsing, no guessing involved. This results in a significant amount of savings in network traffic (no syncing), CPU time (no combat log parsing) and memory used (50 kb vs over 1 mb). Gone are the days of boss modules being needed to be coded for threat for each specific boss, such as Nightbane wiping threat on landing (we used the /yell trigger Nightbane does).
Since patch 3.0.2, Omen no longer does any of these things and the need for a threat library is no longer necessary. Omen3 uses Blizzard's new in-built threat monitor to obtain exact values of every members threat. This means Omen3 has no need for synchronisation of data, combat log parsing or guessing, resulting in a significant increase in performance with regards to network traffic, CPU time and memory used. The implementation of boss modules for specific threat events (such as Nightbane wiping threat on landing) are also no longer necessary.
The drawbacks? The frequency of the updates is much slower, and you can only obtain threat from a mob you are in direct combat with, and only if someone is targetting it in your party/raid. The benefits? You can now see threat of NPCs (think Human Kalecgos) on a mob, provided someone in the raid has them targetted.
Further benefits of this new implementation include the addition of NPC threat on a mob (eg, Human Kalecgos). However, there are some drawbacks; frequency of updates are much slower, threat details cannot be obtained unless somebody in your party/raid are targetting the mob and it is also not possible to obtain threat from a mob you are not in direct combat with.
|cffffd200How do I make Omen3 look like Omen2?|r
Change the Background Texture and Border Texture both to Blizzard Tooltip, change the Background Color to black (by dragging the luminance bar to the bottom), and the Border Color to blue.
Change the both the Background Texture and Border Texture to Blizzard Tooltip, change the Background Color to black (by dragging the luminance bar to the bottom), and the Border Color to blue.
|cffffd200Why does no threat data show on a mob when I target it even though it is in combat?|r
The Blizzard threat API does not return threat data on any mob you are not in direct combat with. We suspect this is an effort on Blizzard's part to save bandwidth.
The Blizzard threat API does not return threat data on any mob you are not in direct combat with. We suspect this is an effort on Blizzard's part to save network traffic.
|cffffd200Does Omen3 sync or parse the combat log?|r
No. Omen3 does not attempt to sync or parse the combat log. Currently there is no intention to do so.
No. Omen3 does not attempt to sync or parse the combat log. Currently there are no intentions to do so.
|cffffd200The threat updates are slow...|r
@@ -235,6 +243,6 @@ Sunder Armour ________ 345 + 5%AP
Thunder Clap _________ 1.85 x damage
Vigilance ____________ 10% of target's generated threat (stance modifier is not applied)
You do not gain threat for refecting spells targetted at allies with Improved Spell Reflect. When you reflect a spell for an ally, your ally gains the threat for the damage dealt by the reflected spell.
You do not gain threat for reflecting spells targetted at allies with Improved Spell Reflect. When you reflect a spell for an ally, your ally gains the threat for the damage dealt by the reflected spell.
]]
Omen.lua
+14 -10
View File
@@ -1274,12 +1274,12 @@ do
local Omen_TitleDropDownMenu = CreateFrame("Frame", "Omen_TitleDropDownMenu")
Omen_TitleDropDownMenu.displayMode = "MENU"
Omen_TitleDropDownMenu.initialize = function(self, level)
if (not level) then return end
if not level then return end
for k in pairs(info) do info[k] = nil end
if (level == 1) then
if level == 1 then
-- Create the title of the menu
info.isTitle = 1
info.text = "Omen Quick Menu"
info.text = L["Omen Quick Menu"]
info.notCheckable = 1
UIDropDownMenu_AddButton(info, level)
@@ -1304,9 +1304,13 @@ do
info.func = function() Omen:ShowConfig() end
UIDropDownMenu_AddButton(info, level)
info.text = L["Hide Omen"]
info.func = function() Omen:Toggle() end
UIDropDownMenu_AddButton(info, level)
-- Close menu item
info.text = CLOSE
info.func = CloseDropDownMenus
info.func = function() CloseDropDownMenus() end
info.checked = nil
info.arg1 = nil
info.notCheckable = 1
@@ -1806,20 +1810,20 @@ local options = {
Sound = {
type = "toggle",
order = 2,
name = "Enable Sound",
desc = "Enable Sound",
name = L["Enable Sound"],
desc = L["Causes Omen to play a chosen sound effect"],
},
Flash = {
type = "toggle",
order = 3,
name = "Enable Screen Flash",
desc = "Enable Screen Flash",
name = L["Enable Screen Flash"],
desc = L["Causes the entire screen to flash red momentarily"],
},
Shake = {
type = "toggle",
order = 4,
name = "Enable Screen Shake",
desc = "Enable Screen Shake",
name = L["Enable Screen Shake"],
desc = L["Causes the entire game world to shake momentarily. This option only works if nameplates are turned off."],
},
Message = {
type = "toggle",