Exiles/coa-details
3
0
Fork 0
Code Pull Requests Actions Packages Releases 2 Wiki Activity

Remove UnitIsUnit('player',X) checks, and change UnitName calls to use Details.playername

Browse Source
This commit is contained in:
Flamanis
2023-11-09 00:45:20 -06:00
parent bc0070cc6d
commit ce35713b50
10 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
classes/container_actors.lua
+1 -1
View File
@@ -784,7 +784,7 @@ end
--check ownership
if (petOwnerObject and Details.immersion_pets_on_solo_play) then
if (UnitIsUnit("player", petOwnerObject.nome)) then
if (Details.playername == petOwnerObject.nome) then
if (not Details.in_group) then
newActor.grupo = true
end
core/gears.lua
+1 -1
View File
@@ -1678,7 +1678,7 @@ function Details.Database.StoreEncounter(combat)
bossData.time_incombat = bossData.time_incombat + encounterElapsedTime
--player best dps
local player = combat(DETAILS_ATTRIBUTE_DAMAGE, UnitName("player"))
local player = combat(DETAILS_ATTRIBUTE_DAMAGE, Details.playername)
if (player) then
local playerDps = player.total / encounterElapsedTime
if (playerDps > bossData.dps_best) then
core/parser.lua
+4 -4
View File
@@ -2813,7 +2813,7 @@
end
end
if (override_aura_spellid[spellId] and UnitIsUnit(sourceName, "player")) then
if (override_aura_spellid[spellId] and sourceName == Details.playername) then
local auraName, texture, count, auraType, duration, expirationTime, sourceUnit, isStealable, nameplateShowPersonal, spellId, canApplyAura, isBossAura, isFromPlayerOrPlayerPet, nameplateShowAll, timeMod, v1, v2, v3, v4, v5 = Details:FindBuffCastedByUnitName(sourceName, spellId, sourceName)
if (auraName) then
local overrideTable = override_aura_spellid[spellId]
@@ -6822,7 +6822,7 @@ local SPELL_POWER_PAIN = SPELL_POWER_PAIN or (PowerEnum and PowerEnum.Pain) or 1
end
--player
local playerName = GetUnitName("player", true)
local playerName = Details.playername
local playerGUID = UnitGUID("player")
raid_members_cache[playerGUID] = playerName
@@ -6837,7 +6837,7 @@ local SPELL_POWER_PAIN = SPELL_POWER_PAIN or (PowerEnum and PowerEnum.Pain) or 1
auto_regen_cache[playerName] = auto_regen_power_specs[Details.cached_specs[playerGUID]]
end
else
local playerName = GetUnitName("player", true)
local playerName = Details.playername
local playerGUID = UnitGUID("player")
raid_members_cache[playerGUID] = playerName
@@ -7089,7 +7089,7 @@ local SPELL_POWER_PAIN = SPELL_POWER_PAIN or (PowerEnum and PowerEnum.Pain) or 1
return unitId
end
end
if (UnitName("player") == unitName) then
if (Details.playername == unitName) then
return "player"
end
end
core/util.lua
+1 -1
View File
@@ -1349,7 +1349,7 @@ end
end
end
end
if (UnitName ("player") == name) then
if (UnitName ("player") == name or Details.playername == name) then
return UnitGUID("player")
end
return nil
functions/deathrecap.lua
+1 -1
View File
@@ -601,7 +601,7 @@ hooksecurefunc (_G, "DeathRecap_LoadUI", function()
hooksecurefunc (_G, "DeathRecapFrame_OpenRecap", function(RecapID)
local currentCombat = Details:GetCurrentCombat()
--get the player current death and link the death table with the death recapID
local playerDeaths = currentCombat:GetPlayerDeaths(UnitName("player"))
local playerDeaths = currentCombat:GetPlayerDeaths(Details.playername)
if (playerDeaths) then
local latestDeath = playerDeaths[#playerDeaths]
if (latestDeath) then
functions/dungeon.lua
+2 -2
View File
@@ -151,13 +151,13 @@ local tickerCallback = function(tickerObject)
--tick damage
local totalPlayers = GetNumGroupMembers()
for i = 1, totalPlayers-1 do
local unitName, unitRealm = UnitName ("party" .. i)
local unitName, unitRealm = UnitFullName ("party" .. i)
if (unitName) then
addPlayerDamage(unitName, unitRealm)
end
end
addPlayerDamage(UnitName("player"))
addPlayerDamage(UnitFullName("player"))
end
function mythicDungeonCharts:OnBossDefeated()
functions/pack.lua
+2 -2
View File
@@ -427,7 +427,7 @@ function Details.packFunctions.PackDamage(combatObject)
local actorsToPack = {}
--get the player object from the combat > damage container
local playerName = UnitName("player")
local playerName = Details.playername
local playerObject = combatObject:GetActor(DETAILS_ATTRIBUTE_DAMAGE, playerName)
if (not playerObject) then
if (isDebugging) then
@@ -677,7 +677,7 @@ function Details.packFunctions.PackHeal(combatObject)
local actorsToPack = {}
--get the player object from the combat > damage container
local playerName = UnitName("player")
local playerName = Details.playername
local playerObject = combatObject:GetActor(DETAILS_ATTRIBUTE_HEAL, playerName)
if (not playerObject) then
if (isDebugging) then
functions/spec_augmentation.lua
+2 -2
View File
@@ -21,7 +21,7 @@ function augmentationFunctions.BuffIn(token, time, sourceSerial, sourceName, sou
end
elseif (spellId == 413984) then --ss
if (UnitExists(targetName) and not UnitIsUnit("player", targetName)) then
if (UnitExists(targetName) and targetName ~= Details.playername) then
local auraName, texture, count, auraType, duration, expirationTime, sourceUnit, isStealable, nameplateShowPersonal, spellId, canApplyAura, isBossAura, isFromPlayerOrPlayerPet, nameplateShowAll, timeMod, v1, v2, v3, v4, v5 = Details:FindBuffCastedByUnitName(targetName, spellId, sourceName)
local versaGained = v1
if (type(versaGained) == "number") then
@@ -92,7 +92,7 @@ function augmentationFunctions.BuffRefresh(token, time, sourceSerial, sourceName
end
elseif (spellId == 413984) then --ss
if (UnitExists(targetName) and not UnitIsUnit("player", targetName)) then
if (UnitExists(targetName) and targetName ~= Details.playername) then
local auraName, texture, count, auraType, duration, expirationTime, sourceUnit, isStealable, nameplateShowPersonal, spellId, canApplyAura, isBossAura, isFromPlayerOrPlayerPet, nameplateShowAll, timeMod, v1, v2, v3, v4, v5 = Details:FindBuffCastedByUnitName (targetName, spellId, sourceName)
local versaGained = v1
functions/timedata.lua
+1 -1
View File
@@ -590,7 +590,7 @@ function Details222.TimeCapture.StartCombatTimer(combatObject)
Details222.TimeCapture.CombatTimeTicker = C_Timer.NewTicker(1, combatTimeTicker)
--debug: starting only for the player
Details222.TimeCapture.Start(UnitName("player"), DETAILS_ATTRIBUTE_DAMAGE)
Details222.TimeCapture.Start(Details.playername, DETAILS_ATTRIBUTE_DAMAGE)
end
--combat ended on Details! end
plugins/Details_Streamer/Details_Streamer.lua
+5 -1
View File
@@ -2356,7 +2356,11 @@ function StreamOverlay:OnEvent (_, event, ...)
local AddonName = select (1, ...)
if (AddonName == "Details_Streamer") then
playerName = UnitName ("player")
local interimPlayerName, playerRealm = UnitFullName ("player")
if(select(4, GetBuildInfo()) >= 100200) then
playerName = interimPlayerName .. '-' .. playerRealm
end
if (_G.Details) then