Exiles/coa-details
3
0
Fork 0
Code Pull Requests Actions Packages Releases 2 Wiki Activity

Re-making the commit for reported issues on classic wow

Browse Source
This commit is contained in:
Tercioo
2019-05-28 13:25:48 -03:00
parent 7c9a3957b4
commit 6069094af7
3 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/parser.lua
+1 -1
View File
@@ -3636,7 +3636,7 @@ local SPELL_POWER_PAIN = SPELL_POWER_PAIN or (PowerEnum and PowerEnum.Pain) or 1
_table_insert (_current_combat.last_events_tables, #_current_combat.last_events_tables+1, t)
--> check if this is a mythic+ run
local mythicLevel = C_ChallengeMode.GetActiveKeystoneInfo()
local mythicLevel = C_ChallengeMode and C_ChallengeMode.GetActiveKeystoneInfo() --classic wow doesn't not have C_ChallengeMode API
if (mythicLevel and type (mythicLevel) == "number" and mythicLevel >= 2) then --several checks to be future proof
--> more checks for integrity
if (_detalhes.tabela_overall and _detalhes.tabela_overall.last_events_tables) then
functions/slash.lua
+4
View File
@@ -164,6 +164,10 @@ function SlashCmdList.DETAILS (msg, editbox)
elseif (command == Loc ["STRING_SLASH_CHANGES"] or command == Loc ["STRING_SLASH_CHANGES_ALIAS1"] or command == Loc ["STRING_SLASH_CHANGES_ALIAS2"] or command == "news" or command == "updates") then
_detalhes:OpenNewsWindow()
elseif (command == "discord") then
_detalhes:CopyPaste ("https://discord.gg/AGSzAZX")
elseif (command == "debugwindow") then
local window1 = Details:GetWindow(1)
startup.lua
+9 -1
View File
@@ -339,7 +339,7 @@ function _G._detalhes:Start()
local newFrame = CreateFrame ("frame", "DetailsMythicPlusFrame", UIParent)
newFrame.DevelopmentDebug = false
--disabnling the mythic+ feature if the user is playing in wow classic
--disabling the mythic+ feature if the user is playing in wow classic
if (not DetailsFramework.IsClassicWow()) then
newFrame:RegisterEvent ("CHALLENGE_MODE_START")
newFrame:RegisterEvent ("CHALLENGE_MODE_COMPLETED")
@@ -1875,6 +1875,14 @@ function _G._detalhes:Start()
--> override the overall data flag on this release only (remove on the next release)
--Details.overall_flag = 0x10
--show warning message about classic beta
if (not DetailsFramework.IsClassicWow()) then
print ("|CFFFFFF00[Tercioo]: this version of Details! is being ported to Classic WoW, bugs may appear here on BfA, report at Discord (/details discord).")
else
print ("|CFFFFFF00[Tercioo]: thanks for testing Details! Damage Meter for Classic WoW, report bugs at Discord (/details discord).")
end
end