coa.8: simplify title bar + default to AtlasLoot-size window

- Title bar: 'Altoholic <toc version>' (was 'Altoholic v.. by Thaoky (Edited by
  Telkar-RG 1.04a)'); reads GetAddOnMetadata Version so it tracks releases. Drop
  dead VERSION_STRING.
- Default UIScale 1.0 -> 1.4 (~AtlasLoot 1105x640). Apply scale in OnShow (was only
  applied after visiting Options); one-time migration bumps old-default profiles.
  Options reset/default slider -> 1.4.

Altoholic/Altoholic.lua

@@ -17,7 +17,6 @@ local TEAL		= "|cFF00FF9A"
 local GOLD		= "|cFFFFD700"
 
 local THIS_ACCOUNT = "Default"
-local VERSION_STRING = "1.04a"
 
 Altoholic.ClassInfo = {
 	["MAGE"] = "|cFF69CCF0",
@@ -334,7 +333,10 @@ function addon:OnEnable()
 	addon:RegisterEvent("AUCTION_HOUSE_SHOW", addon.AuctionHouse.OnShow)
 	addon:RegisterEvent("PLAYER_TALENT_UPDATE", addon.Talents.OnUpdate);
 	
-	AltoholicFrameName:SetText("Altoholic |cFFFFFFFF".. addon.Version .. "|r by |cFF69CCF0Thaoky|r" .. " (Edited by |cFF69CCF0Telkar-RG|r ".."|cFFFFFFFF".. VERSION_STRING .."|r)")
+	-- CoA: just "Altoholic <version>" in the title bar (Exiles branding + author credit live in the .toc).
+	-- Read the live .toc Version so it tracks each -coa.N release without editing this string.
+	local titleVersion = GetAddOnMetadata(addonName, "Version") or addon.Version
+	AltoholicFrameName:SetText("Altoholic |cFFFFFFFF".. titleVersion .."|r")
 
 	local realm = GetRealmName()
 	local player = UnitName("player")
@@ -400,7 +402,17 @@ function addon:ToggleUI()
 end
 
 function addon:OnShow()
-	SetPortraitTexture(AltoholicFramePortrait, "player");	
+	SetPortraitTexture(AltoholicFramePortrait, "player");
+
+	-- CoA: apply the saved UI scale on every open. Upstream only ran SetScale after the
+	-- Options tab was visited, so the window opened un-scaled. One-time bump of profiles
+	-- still on the old 1.0 default to the AtlasLoot-ish 1.4 default; a custom scale is kept.
+	local O = addon.db.global.options
+	if not O.coaScaleDefaulted then
+		O.coaScaleDefaulted = true
+		if (O.UIScale or 1.0) == 1.0 then O.UIScale = 1.4 end
+	end
+	AltoholicFrame:SetScale(O.UIScale or 1.4)
 
 	addon.Characters:BuildList()
 	addon.Characters:BuildView()

Altoholic/Altoholic.toc

@@ -13,7 +13,7 @@
 
 ## Author: Thaoky, Telkar-RG
 ## X-Edited-By: Exiles (Sub-Net) — florian.berthold@sub-net.at
-## Version: 3.3.002b-coa.6
+## Version: 3.3.002b-coa.8
 ## X-Category: Inventory, Tradeskill, Mail
 ## X-Localizations: enUS, frFR, zhCN, zhTW, deDE, koKR, esES, esMX, ruRU
 ## X-Website: http://wow.curse.com/downloads/wow-addons/details/altoholic.aspx

Altoholic/Core.lua

@@ -85,7 +85,7 @@ local AddonDB_Defaults = {
 			AccSharingHandlerEnabled = 0,	-- account sharing communication handler is disabled by default
 			GuildBankAutoUpdate = 0,		-- can the guild bank tabs update requests be answered automatically or not.
 			GuildHandlerEnabled = 1,		-- guild communication handler is enabled by default
-			UIScale = 1.0,
+			UIScale = 1.4,		-- CoA: open at ~AtlasLoot footprint (832x447 * 1.4 = 1165x626 vs AtlasLoot 1105x640)
 			UITransparency = 1.0,
 			ClampWindowToScreen = 0,
 			

Altoholic/Frames/Skills.lua

@@ -119,7 +119,7 @@ function ns:Update()
 					else
 						icon = ""
 					end
-					field = Characters:GetField(line, "skillRank1")
+					field = Characters:GetField(line, "skillRank1") or 0
 					_G[entry..i.."Skill1NormalText"]:SetText(icon .. ns:GetColor(field) .. field)
 					
 					-- profession 2
@@ -130,29 +130,29 @@ function ns:Update()
 					else
 						icon = ""
 					end
-					field = Characters:GetField(line, "skillRank2")
+					field = Characters:GetField(line, "skillRank2") or 0
 					_G[entry..i.."Skill2NormalText"]:SetText(icon .. ns:GetColor(field) .. field)
 					
 					-- cooking
 					-- icon = addon:TextureToFontstring(addon:GetSpellIcon(2550), size, size) .. " "
 					icon = addon:TextureToFontstring2(addon:GetSpellIcon(2550), size, size, inset, inset, inset, inset) .. " "
-					field = Characters:GetField(line, "cooking")
+					field = Characters:GetField(line, "cooking") or 0
 					_G[entry..i.."CookingNormalText"]:SetText(icon .. ns:GetColor(field) .. field)
 					
 					-- first aid
 					-- icon = addon:TextureToFontstring(addon:GetSpellIcon(3273), size, size) .. " "
 					icon = addon:TextureToFontstring2(addon:GetSpellIcon(3273), size, size, inset, inset, inset, inset) .. " "
-					field = Characters:GetField(line, "firstaid")
+					field = Characters:GetField(line, "firstaid") or 0
 					_G[entry..i.."FirstAidNormalText"]:SetText(icon .. ns:GetColor(field) .. field)
 					
 					-- fishing
 					-- icon = addon:TextureToFontstring(addon:GetSpellIcon(7733), size, size) .. " "
 					icon = addon:TextureToFontstring2(addon:GetSpellIcon(7733), size, size, inset, inset, inset, inset) .. " "
-					field = Characters:GetField(line, "fishing")
+					field = Characters:GetField(line, "fishing") or 0
 					_G[entry..i.."FishingNormalText"]:SetText(icon .. ns:GetColor(field) .. field)
 					
 					-- riding
-					field = Characters:GetField(line, "riding")
+					field = Characters:GetField(line, "riding") or 0
 					if field >= 300 then
 						-- icon = addon:TextureToFontstring("Interface\\Icons\\Ability_Mount_Gryphon_01", size, size) .. " "
 						icon = addon:TextureToFontstring2("Interface\\Icons\\ability_mount_drake_bronze", size, size, inset, inset, inset, inset)
@@ -400,6 +400,7 @@ end
 local skillColors = { RECIPE_GREY, RED, ORANGE, YELLOW, GREEN }
 
 function ns:GetColor(rank, skillCap)
+	rank = rank or 0		-- CoA: skill fields are nil for chars DataStore_Characters hasn't scanned
 	skillCap = skillCap or 450
 	return skillColors[ floor(rank / (skillCap/4)) + 1 ]
 end

Altoholic/Frames/TabOptions.xml

@@ -161,7 +161,7 @@
 				</Scripts>
 			</Slider>
 			
-			<Slider name="$parent_SliderScale" inherits="OptionsSliderTemplate"  minValue="0.5" maxValue="4.0" defaultValue="1.0" valueStep="0.1">
+			<Slider name="$parent_SliderScale" inherits="OptionsSliderTemplate"  minValue="0.5" maxValue="4.0" defaultValue="1.4" valueStep="0.1">
 				<Size>
 					<AbsDimension x="180" y="16"/>
 				</Size>
@@ -199,10 +199,10 @@
 				<Scripts>
 					<OnClick>
 						local name = self:GetParent():GetName()
-						_G[name .. "_SliderScale"]:SetValue(1.0)
-						_G[name .. "_SliderScaleText"]:SetText(format("%s (%1.1f)", UI_SCALE, 1.0));
-						AltoholicFrame:SetScale(1.0)
-						Altoholic.Options:Set("UIScale", 1.0)
+						_G[name .. "_SliderScale"]:SetValue(1.4)
+						_G[name .. "_SliderScaleText"]:SetText(format("%s (%1.1f)", UI_SCALE, 1.4));
+						AltoholicFrame:SetScale(1.4)
+						Altoholic.Options:Set("UIScale", 1.4)
 					</OnClick>
 				</Scripts>
 			</Button>

README.md

@@ -5,6 +5,8 @@ Altoholic: modified development for WotLK
 
 Ported for the Ascension CoA (Vol'jin) 3.3.5a client by the Exiles guild. Released as `*-coa.N` tags via Gitea Actions; see `Exiles/coa-altoholic`.
 
+- **3.3.002b-coa.8** — Title bar reads just `Altoholic <version>` (from the live `.toc`), dropping the "by Thaoky (Edited by Telkar-RG 1.04a)" string. Window now opens at the AtlasLoot-ish default scale (`UIScale` 1.4, ≈ 1105×640); scale is applied on every open (upstream only applied it after visiting Options), with a one-time bump for profiles still on the old 1.0 default.
+- **3.3.002b-coa.7** — Skills tab: `GetColor()` now nil-safe and the per-skill rank fields (`skillRank1/2`, `cooking`, `firstaid`, `fishing`, `riding`) default to `0` — they're nil for chars `DataStore_Characters` hasn't scanned, which crashed the Skills summary (`floor(rank/…)` arithmetic and the `>= 300` riding check).
 - **3.3.002b-coa.6** — Final straggler: guarded `AccountSharing.lua` realm/name line (name getter was the last `format` arg, so a no-value collapsed it to a format error). Concludes the frame sweep.
 - **3.3.002b-coa.5** — Refactor + completeness pass:
   - Extracted the duplicated character header/row blocks into `Altoholic:AddCharacterTooltipHeader()` and `Altoholic:SetCharacterRowNameLevel()` — the nil-guards now live in one place instead of being copy-pasted across frames.