coa.28: fix login scan in 9 DataStore modules (the 'data not saved' root cause)

Quests, Achievements, Reputations, Pets, Stats, Skills, Crafts, Spells, Talents all had
the ghost-gated PLAYER_ALIVE scan (DEBUG 2025-07-21 leftover): they only scanned when the
player died and released spirit, so their data never populated on a normal login. Now
scan once per session at login (addon.coaScannedThisSession guard), matching the earlier
DataStore_Characters/_Inventory fix. This is why reputations/recipes/quests/pets/etc were
'not saved'.

Altoholic/Altoholic.lua

@@ -338,7 +338,7 @@ function addon:OnEnable()
 	-- CoA: use a Lua constant, not GetAddOnMetadata — TOC metadata is cached at game launch
 	-- and does NOT refresh on /reload, so the .toc version looked stale ("still .18"). A Lua
 	-- constant re-evaluates on every /reload, giving a truthful loaded-code version. Bump with the .toc.
-	AltoholicFrameName:SetText("Altoholic |cFFFFFFFF3.3.002b-coa.26|r")
+	AltoholicFrameName:SetText("Altoholic |cFFFFFFFF3.3.002b-coa.28|r")
 
 	local realm = GetRealmName()
 	local player = UnitName("player")

Altoholic/Altoholic.toc

@@ -13,7 +13,7 @@
 
 ## Author: Thaoky, Telkar-RG
 ## X-Edited-By: Exiles (Sub-Net) — florian.berthold@sub-net.at
-## Version: 3.3.002b-coa.26
+## Version: 3.3.002b-coa.28
 ## X-Category: Inventory, Tradeskill, Mail
 ## X-Localizations: enUS, frFR, zhCN, zhTW, deDE, koKR, esES, esMX, ruRU
 ## X-Website: http://wow.curse.com/downloads/wow-addons/details/altoholic.aspx

Altoholic/Frames/Skills.lua

@@ -66,6 +66,7 @@ function ns:Update()
 				items[#items + 1] = { kind = "skill", viewLine = viewLine, character = character,
 					spellID = 33388, name = (L and L["Riding"]) or "Riding", rank = riding, maxRank = 300 }
 			end
+			items[#items + 1] = { kind = "spacer" }		-- blank row between characters
 		end
 	end
 
@@ -82,14 +83,21 @@ function ns:Update()
 			_G[e.."FishingNormalText"]:SetText("")
 			_G[e.."RidingNormalText"]:SetText("")
 
-			if item.kind == "header" then
-				-- character header: colored name + (class) across the row, no rank column
+			if item.kind == "spacer" then
+				-- blank separator row between characters
 				_G[e.."Name"]:SetPoint("TOPLEFT", 15, 0)
+				_G[e.."NameNormalText"]:SetText("")
+				_G[e.."Level"]:SetText("")
+			elseif item.kind == "header" then
+				-- character header: gold "Name (Class)" across the row, no rank column
+				_G[e.."Name"]:SetPoint("TOPLEFT", 12, 0)
 				_G[e.."Name"]:SetWidth(420)
 				_G[e.."NameNormalText"]:SetWidth(420)
+				local cname = Characters:GetInfo(item.viewLine) or "?"		-- name from the key, always present (scanned char.name can be nil)
 				local locClass, engClass = DS:GetCharacterClass(item.character)
 				local className = Altoholic:GetCoAClassName(engClass) or locClass or ""		-- CoA: PROPHET->Venomancer, MONK->Templar, …
-				_G[e.."NameNormalText"]:SetText( (DS:GetColoredCharacterName(item.character) or "?") .. "  " .. WHITE .. "(" .. className .. ")" )
+				local classColor = DS:GetClassColor(item.character) or WHITE
+				_G[e.."NameNormalText"]:SetText( classColor .. cname .. "|r " .. WHITE .. "(" .. className .. ")" )
 				_G[e.."Level"]:SetText("")
 			else
 				-- profession row: [icon] name in the Name cell (indented), rank/max in its own column
@@ -97,13 +105,13 @@ function ns:Update()
 				if item.spellID then
 					iconEsc = addon:TextureToFontstring2(addon:GetSpellIcon(item.spellID), size, size, inset, inset, inset, inset) .. " "
 				end
-				_G[e.."Name"]:SetPoint("TOPLEFT", 38, 0)
-				_G[e.."Name"]:SetWidth(200)
-				_G[e.."NameNormalText"]:SetWidth(200)
+				_G[e.."Name"]:SetPoint("TOPLEFT", 34, 0)
+				_G[e.."Name"]:SetWidth(170)
+				_G[e.."NameNormalText"]:SetWidth(170)
 				_G[e.."NameNormalText"]:SetText( iconEsc .. WHITE .. item.name )
 
 				local cap = (item.maxRank > 0) and item.maxRank or 450
-				_G[e.."Level"]:SetPoint("TOPLEFT", 250, 0)
+				_G[e.."Level"]:SetPoint("TOPLEFT", 195, 0)
 				_G[e.."Level"]:SetWidth(120)
 				_G[e.."Level"]:SetJustifyH("LEFT")
 				_G[e.."Level"]:SetText( ns:GetColor(item.rank, cap) .. item.rank .. " / " .. item.maxRank )

DataStore_Achievements/DataStore_Achievements.lua

@@ -235,7 +235,8 @@ end
 -- *** EVENT HANDLERS ***
 function addon:PLAYER_ALIVE()
 	-- print("DataStore_Achievements.lua") -- DEBUG 2025 07 21
-	if not UnitIsGhost("player") then return end -- only scan if player released spirit and went to graveyard
+	if addon.coaScannedThisSession then return end		-- CoA: scan once at login (was ghost-gated, so data never saved on a normal login - the cause of "data not saved")
+	addon.coaScannedThisSession = true
 	
 	ScanAllAchievements()
 	ScanProgress()

DataStore_Crafts/DataStore_Crafts.lua

@@ -546,7 +546,8 @@ end
 -- *** Event Handlers ***
 local function OnPlayerAlive()
 	-- print("DataStore_Crafts.lua") -- DEBUG 2025 07 21
-	if not UnitIsGhost("player") then return end -- only scan if player released spirit and went to graveyard
+	if addon.coaScannedThisSession then return end		-- CoA: scan once at login (was ghost-gated, so data never saved on a normal login - the cause of "data not saved")
+	addon.coaScannedThisSession = true
 	
 	ScanProfessionLinks()
 end

DataStore_Pets/DataStore_Pets.lua

@@ -46,7 +46,8 @@ end
 -- *** Event Handlers ***
 local function OnPlayerAlive()
 	-- print("DataStore_Pets.lua") -- DEBUG 2025 07 21
-	if not UnitIsGhost("player") then return end -- only scan if player released spirit and went to graveyard
+	if addon.coaScannedThisSession then return end		-- CoA: scan once at login (was ghost-gated, so data never saved on a normal login - the cause of "data not saved")
+	addon.coaScannedThisSession = true
 	
 	ScanCompanions("CRITTER")
 	ScanCompanions("MOUNT")

DataStore_Quests/DataStore_Quests.lua

@@ -177,7 +177,8 @@ end
 -- *** Event Handlers ***
 local function OnPlayerAlive()
 	-- print("DataStore_Quests.lua") -- DEBUG 2025 07 21
-	if not UnitIsGhost("player") then return end -- only scan if player released spirit and went to graveyard
+	if addon.coaScannedThisSession then return end		-- CoA: scan once at login (was ghost-gated, so data never saved on a normal login - the cause of "data not saved")
+	addon.coaScannedThisSession = true
 	
 	ScanQuests()
 end

DataStore_Reputations/DataStore_Reputations.lua

@@ -177,7 +177,8 @@ end
 -- *** EVENT HANDLERS ***
 function addon:PLAYER_ALIVE()
 	-- print("DataStore_Reputations.lua") -- DEBUG 2025 07 21
-	if not UnitIsGhost("player") then return end -- only scan if player released spirit and went to graveyard
+	if addon.coaScannedThisSession then return end		-- CoA: scan once at login (was ghost-gated, so data never saved on a normal login - the cause of "data not saved")
+	addon.coaScannedThisSession = true
 	
 	ScanReputations()
 end

DataStore_Skills/DataStore_Skills.lua

@@ -239,7 +239,8 @@ end
 -- *** EVENT HANDLERS ***
 function addon:PLAYER_ALIVE()
 	-- print("DataStore_Skills.lua") -- DEBUG 2025 07 21
-	if not UnitIsGhost("player") then return end -- only scan if player released spirit and went to graveyard
+	if addon.coaScannedThisSession then return end		-- CoA: scan once at login (was ghost-gated, so data never saved on a normal login - the cause of "data not saved")
+	addon.coaScannedThisSession = true
 
 	ScanSkills()
 end

DataStore_Spells/DataStore_Spells.lua

@@ -105,7 +105,8 @@ end
 -- *** EVENT HANDLERS ***
 function addon:PLAYER_ALIVE()
 	-- print("DataStore_Spells.lua") -- DEBUG 2025 07 21
-	if not UnitIsGhost("player") then return end -- only scan if player released spirit and went to graveyard
+	if addon.coaScannedThisSession then return end		-- CoA: scan once at login (was ghost-gated, so data never saved on a normal login - the cause of "data not saved")
+	addon.coaScannedThisSession = true
 	
 	ScanSpells()
 end

DataStore_Stats/DataStore_Stats.lua

@@ -156,7 +156,8 @@ end
 -- *** EVENT HANDLERS ***
 function addon:PLAYER_ALIVE()
 	-- print("DataStore_Stats.lua") -- DEBUG 2025 07 21
-	if not UnitIsGhost("player") then return end -- only scan if player released spirit and went to graveyard
+	if addon.coaScannedThisSession then return end		-- CoA: scan once at login (was ghost-gated, so data never saved on a normal login - the cause of "data not saved")
+	addon.coaScannedThisSession = true
 	
 	ScanStats()
 end

DataStore_Talents/DataStore_Talents.lua

@@ -419,7 +419,8 @@ end
 -- *** EVENT HANDLERS ***
 function addon:PLAYER_ALIVE()
 	-- print("DataStore_Talents.lua") -- DEBUG 2025 07 21
-	if not UnitIsGhost("player") then return end -- only scan if player released spirit and went to graveyard
+	if addon.coaScannedThisSession then return end		-- CoA: scan once at login (was ghost-gated, so data never saved on a normal login - the cause of "data not saved")
+	addon.coaScannedThisSession = true
 	
 	ScanTalents()
 	ScanTalentReference()