coa.11: fix Skills tab crash (Skill1 ButtonText name collision)
release / release (push) Successful in 5s

$parentSkill1 inherited AltoSkillButtonTemplate AND redefined a $parentNormalText
ButtonText -> duplicate global name left Skill1NormalText nil and crashed the Skills
tab on open. Made $parentSkill1 self-contained (own 325px ButtonText + scripts).
This commit is contained in:
2026-05-29 17:59:05 +02:00
parent 0565051302
commit e555a22f36
2 changed files with 19 additions and 2 deletions
+1 -1
View File
@@ -13,7 +13,7 @@
## Author: Thaoky, Telkar-RG
## X-Edited-By: Exiles (Sub-Net) — florian.berthold@sub-net.at
## Version: 3.3.002b-coa.10
## Version: 3.3.002b-coa.11
## X-Category: Inventory, Tradeskill, Mail
## X-Localizations: enUS, frFR, zhCN, zhTW, deDE, koKR, esES, esMX, ruRU
## X-Website: http://wow.curse.com/downloads/wow-addons/details/altoholic.aspx
+18 -1
View File
@@ -112,7 +112,11 @@
profession (incl. customs Woodcutting/Woodworking) as icon+rank
segments, replacing the old fixed Prof.1/Prof.2 columns. Width
(325) must match the "Professions" header in TabSummary.lua. -->
<Button name="$parentSkill1" inherits="AltoSkillButtonTemplate" id="1">
<!-- CoA: self-contained (NOT inheriting AltoSkillButtonTemplate) so the wide
325px professions-strip ButtonText is the ONLY $parentNormalText on this
button. Inheriting + redefining ButtonText collided on the global name and
left Skill1NormalText nil (crashed the Skills tab). -->
<Button name="$parentSkill1" id="1">
<Size>
<AbsDimension x="325" y="18"/>
</Size>
@@ -135,6 +139,19 @@
</Anchor>
</Anchors>
</ButtonText>
<Scripts>
<OnEnter>
Altoholic.TradeSkills:OnEnter(self)
</OnEnter>
<OnClick>
Altoholic.TradeSkills:OnClick(self, button)
</OnClick>
<OnLeave>
AltoTooltip:Hide();
</OnLeave>
</Scripts>
<NormalFont style="GameFontNormalSmallLeft"/>
<HighlightFont style="GameFontHighlightSmallLeft"/>
</Button>
<Button name="$parentCooking" inherits="AltoSkillButtonTemplate" id="3">
<Anchors>