Revisit Creature Types/Families

Removed a small number of localizations that can be extracted via GetFactionInfoByID(id).
There are more that could be cleaned up using regex, but that might make things look a bit odd, for now, I’m happy with this.
This approach is preferable to remove unnecessary variables saved.

WeakAuras/Types.lua

@@ -2639,9 +2639,9 @@ end
 Private.creature_type_types = {
   [1] = L["Beast"],
   [2] = L["Dragonkin"],
-  [3] = L["Demon"],
-  [4] = L["Elemental"],
-  [5] = L["Giant"],
+  [3] = GetFactionInfoByID(73) or "", -- Demon
+  [4] = GetFactionInfoByID(74) or "", -- Elemental
+  [5] = GetFactionInfoByID(511) or "", -- Giant
   [6] = L["Undead"],
   [7] = L["Humanoid"],
   [8] = L["Critter"],
@@ -2657,9 +2657,9 @@ Private.creature_type_types = {
 Private.ExecEnv.creature_type_name_to_id = {
   [L["Beast"]] = 1,
   [L["Dragonkin"]] = 2,
-  [L["Demon"]] = 3,
-  [L["Elemental"]] = 4,
-  [L["Giant"]] = 5,
+  [GetFactionInfoByID(73) or ""] = 3, -- Demon
+  [GetFactionInfoByID(74) or ""] = 4, -- Elemental
+  [GetFactionInfoByID(511) or ""] = 5, -- Giant
   [L["Undead"]] = 6,
   [L["Humanoid"]] = 7,
   [L["Critter"]] = 8,
@@ -2688,7 +2688,7 @@ Private.creature_family_types = {
   [16] = L["Voidwalker"],
   [17] = L["Succubus"],
   [19] = L["Doomguard"],
-  [20] = L["Scorpid"],
+  [20] = L[GetFactionInfoByID(309) or ""], -- Scorpid
   [21] = L["Turtle"],
   [23] = L["Imp"],
   [24] = L["Bat"],
@@ -2698,7 +2698,7 @@ Private.creature_family_types = {
   [28] = L["Remote Control"],
   [29] = L["Felguard"],
   [30] = L["Dragonhawk"],
-  [31] = L["Ravager"],
+  [31] = GetFactionInfoByID(1039) or "", -- Ravager
   [32] = L["Warp Stalker"],
   [33] = L["Sporebat"],
   [34] = L["Nether Ray"],
@@ -2707,7 +2707,7 @@ Private.creature_family_types = {
   [38] = L["Chimaera"],
   [39] = L["Devilsaur"],
   [40] = L["Ghoul"],
-  [41] = L["Silithid"],
+  [41] = GetFactionInfoByID(249) or "", -- Silithid
   [42] = L["Worm"],
   [43] = L["Rhino"],
   [44] = L["Wasp"],
@@ -2732,7 +2732,7 @@ Private.ExecEnv.creature_family_name_to_id = {
   [L["Voidwalker"]] = 16,
   [L["Succubus"]] = 17,
   [L["Doomguard"]] = 19,
-  [L["Scorpid"]] = 20,
+  [GetFactionInfoByID(309) or ""] = 20, -- Scorpid
   [L["Turtle"]] = 21,
   [L["Imp"]] = 23,
   [L["Bat"]] = 24,
@@ -2742,7 +2742,7 @@ Private.ExecEnv.creature_family_name_to_id = {
   [L["Remote Control"]] = 28,
   [L["Felguard"]] = 29,
   [L["Dragonhawk"]] = 30,
-  [L["Ravager"]] = 31,
+  [GetFactionInfoByID(1039) or ""] = 31, -- Ravager
   [L["Warp Stalker"]] = 32,
   [L["Sporebat"]] = 33,
   [L["Nether Ray"]] = 34,
@@ -2751,7 +2751,7 @@ Private.ExecEnv.creature_family_name_to_id = {
   [L["Chimaera"]] = 38,
   [L["Devilsaur"]] = 39,
   [L["Ghoul"]] = 40,
-  [L["Silithid"]] = 41,
+  [GetFactionInfoByID(249) or ""] = 41, -- Silithid
   [L["Worm"]] = 42,
   [L["Rhino"]] = 43,
   [L["Wasp"]] = 44,