from retail

WeakAurasOptions/RegionOptions/AuraBar.lua

@@ -611,7 +611,7 @@ local function modifyThumbnail(parent, borderframe, data, fullModify, width, hei
     end
 
     if data then
-      local name, icon = WeakAuras.GetNameAndIcon(data)
+      local _, icon = WeakAuras.GetNameAndIcon(data)
       borderframe:SetIcon(icon)
     end
 
@@ -635,7 +635,7 @@ local function createIcon()
   };
 
   -- Create and configure thumbnail
-  local thumbnail = createThumbnail(UIParent);
+  local thumbnail = createThumbnail();
   modifyThumbnail(UIParent, thumbnail, data, nil, 32, 18);
   thumbnail:SetIcon("Interface\\Icons\\INV_Sword_62");
 

WeakAurasOptions/RegionOptions/DynamicGroup.lua

@@ -557,7 +557,7 @@ local function modifyThumbnail(parent, frame, data)
 end
 
 local function createIcon()
-  local thumbnail = createThumbnail(UIParent)
+  local thumbnail = createThumbnail()
   thumbnail.defaultIcon = createAnimatedDefaultIcon(thumbnail)
   return thumbnail
 end

WeakAurasOptions/RegionOptions/Group.lua

@@ -455,7 +455,7 @@ local function createDistributeAlignOptions(id, data)
         end
         local spaced;
         local previousData;
-        for index, childId in pairs(data.controlledChildren) do
+        for _, childId in pairs(data.controlledChildren) do
           local childData = WeakAuras.GetData(childId);
           if(childData) then
             local _, bottom, _, top = getRect(childData);
@@ -672,7 +672,7 @@ end
 
 -- Modify preview thumbnail
 local function modifyThumbnail(parent, frame, data)
-  function frame:SetIcon(path)
+  function frame:SetIcon()
     if data.groupIcon then
       local success = frame.icon:SetTexture(data.groupIcon)
       if success then
@@ -693,12 +693,12 @@ local function modifyThumbnail(parent, frame, data)
     frame.defaultIcon:Show()
   end
 
-  frame:SetIcon(nil)
+  frame:SetIcon()
 end
 
 -- Create "new region" preview
 local function createIcon()
-  local thumbnail = createThumbnail(UIParent)
+  local thumbnail = createThumbnail()
   thumbnail.defaultIcon = createDefaultIcon(thumbnail)
   return thumbnail
 end

WeakAurasOptions/RegionOptions/Model.lua

@@ -188,8 +188,8 @@ local function createIcon()
     width = 40
   };
 
-  local thumbnail = createThumbnail(UIParent);
-  modifyThumbnail(UIParent, thumbnail, data, nil, 50);
+  local thumbnail = createThumbnail();
+  modifyThumbnail(UIParent, thumbnail, data);
 
   return thumbnail;
 end

WeakAurasOptions/RegionOptions/ProgressTexture.lua

@@ -713,7 +713,7 @@ local function createIcon()
     backgroundColor = {0.5, 0.5, 0.5, 0.5}
   };
 
-  local thumbnail = createThumbnail(UIParent);
+  local thumbnail = createThumbnail();
   modifyThumbnail(UIParent, thumbnail, data, nil, 32);
 
   thumbnail.elapsed = 0;

WeakAurasOptions/RegionOptions/StopMotion.lua

@@ -689,7 +689,7 @@ local function createIcon()
         animationType = "progress"
     };
 
-    local thumbnail = createThumbnail(UIParent);
+    local thumbnail = createThumbnail();
     modifyThumbnail(UIParent, thumbnail, data, nil, 75);
 
     thumbnail.elapsed = 0;

WeakAurasOptions/RegionOptions/Text.lua

@@ -4,7 +4,7 @@ local AddonName, OptionsPrivate = ...
 local SharedMedia = LibStub("LibSharedMedia-3.0");
 local L = WeakAuras.L;
 
-local screenWidth, screenHeight = math.ceil(GetScreenWidth() / 20) * 20, math.ceil(GetScreenHeight() / 20) * 20;
+local screenWidth = math.ceil(GetScreenWidth() / 20) * 20
 
 local indentWidth = 0.15
 local hiddenFontExtra = function()
@@ -294,7 +294,7 @@ local function createOptions(id, data)
   end
 
   local total, index = 0, 1
-  for child in OptionsPrivate.Private.TraverseLeafsOrAura(data) do
+  for _ in OptionsPrivate.Private.TraverseLeafsOrAura(data) do
     total = total + 1
   end
 
@@ -414,7 +414,7 @@ local function createIcon()
     displayText = "World\nof\nWarcraft";
   };
 
-  local thumbnail = createThumbnail(UIParent);
+  local thumbnail = createThumbnail();
   modifyThumbnail(UIParent, thumbnail, data);
   thumbnail.mask:SetPoint("BOTTOMLEFT", thumbnail, "BOTTOMLEFT", 3, 3);
   thumbnail.mask:SetPoint("TOPRIGHT", thumbnail, "TOPRIGHT", -3, -3);

WeakAurasOptions/RegionOptions/Texture.lua

@@ -190,7 +190,7 @@ local function createIcon()
     rotation = 0;
   };
 
-  local thumbnail = createThumbnail(UIParent);
+  local thumbnail = createThumbnail();
   modifyThumbnail(UIParent, thumbnail, data, nil, 50);
 
   return thumbnail;