Exiles/coa-weakauras
3
0
Fork 0
Code Pull Requests Actions Packages Releases 2 Wiki Activity

(fix/Prototypes) Class&Spec Load/Triggers

Browse Source 
- Closes #37

Due to an error in the implementation of Class & Spec in Load Conditions and Triggers (Unit Characteristics, Power, Health, Class/Spec, BT2 actualSpec), the system now also applies Retail logic.

As a result of this issue, all data has been erased and must be reselected.
This commit is contained in:
NoM0Re
2025-03-31 20:12:10 +02:00
committed by GitHub
parent 1ed2b94c0e
commit 2e2d21e5f3
4 changed files with 212 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files
WeakAuras/Prototypes.lua
+25 -16
View File
@@ -575,12 +575,12 @@ function WeakAuras.CheckTalentByIndex(index, extraOption)
return result;
end
function WeakAuras.CheckClassSpec(class, test)
if type(class) == "string" or type(test) == "string" then
local spec = WeakAuras.LGT:GetUnitTalentSpec('player') or ""
return (class .. spec) == test
end
return false
function WeakAuras.CheckClassSpec(specID)
specID = tonumber(specID)
if not specID then return end
local class = select(2, UnitClass("player")) or ""
local currentSpec = WeakAuras.LGT:GetUnitTalentSpec("player") or ""
return specID and Private.ExecEnv.GetSpecName(specID) == class .. currentSpec
end
function WeakAuras.CheckNumericIds(loadids, currentId)
@@ -668,8 +668,23 @@ Private.tinySecondFormat = function(value)
end
end
function Private.ExecEnv.GetSpecIcon(classspec)
return Private.spec[classspec] or ""
function Private.ExecEnv.GetSpecIcon(specID)
return specID and Private.specid_to_icon[specID] or ""
end
function Private.ExecEnv.GetSpecName(specID)
return specID and Private.specid_to_name[specID] or ""
end
function Private.ExecEnv.GetSpecID(specName)
return specName and Private.specname_to_id[specName] or 0
end
function WeakAuras.SpecForUnit(unit)
if not unit then return 0 end
local spec = WeakAuras.LGT:GetUnitTalentSpec(unit)
local class = select(2, UnitClass(unit))
return (spec and class) and Private.ExecEnv.GetSpecID(class .. spec) or 0
end
function Private.ExecEnv.ParseStringCheck(input)
@@ -800,12 +815,6 @@ function Private.ExecEnv.CheckCombatLogFlagsObjectType(flags, flagToCheck)
return bit.band(flags, bitToCheck) ~= 0;
end
function WeakAuras.SpecForUnit(unit)
local spec = WeakAuras.LGT:GetUnitTalentSpec(unit)
local class = select(2, UnitClass(unit))
return spec and class and (class .. spec)
end
function WeakAuras.IsSpellKnownForLoad(spell, exact)
local result = WeakAuras.IsSpellKnown(spell)
if exact or result then
@@ -1028,7 +1037,7 @@ Private.load_prototype = {
display = L["Class and Specialization"],
type = "multiselect",
values = "spec_types_all",
test = "WeakAuras.CheckClassSpec(class, %s)",
test = "WeakAuras.CheckClassSpec(%s)",
events = {"UNIT_SPEC_CHANGED_player", "WA_DELAYED_PLAYER_ENTERING_WORLD"},
},
{
@@ -4839,7 +4848,7 @@ Private.event_prototypes = {
local class = select(2, UnitClass("player")) or "UNKNOWN"
return ([[
local specName = WeakAuras.LGT:GetUnitTalentSpec("player") or "Unknown"
local specId = "%s" .. specName
local specId = Private.ExecEnv.GetSpecID("%s" .. specName)
local specIcon = Private.ExecEnv.GetSpecIcon(specId)
]]):format(class)
end,