From 828a99a085978eb5f1ae18a018692c5f294b222a Mon Sep 17 00:00:00 2001 From: Florian Berthold Date: Mon, 11 May 2026 21:48:40 +0200 Subject: [PATCH] Port to Ascension 3.3.5 client - Interface: 11200 -> 30300, add -coa1 version suffix and CoA metadata in VanillaGuide.toc. - Local-shadow arg = {...} inside Di/Dv debug helpers in Core.lua so vararg access works under Lua 5.1 (WoW 3.3.5) instead of Lua 5.0 (WoW 1.12). - Add README-CoA.md documenting fork rationale, patched files, and remaining TODO (in-game smoke test, MetaMap -> pfQuest retarget, CoA-custom content slot, dynamic-scaling picker UX). --- Core.lua | 2 ++ README-CoA.md | 62 ++++++++++++++++++++++++++++++++++++++++++++++++ VanillaGuide.toc | 14 +++++------ 3 files changed, 71 insertions(+), 7 deletions(-) create mode 100644 README-CoA.md diff --git a/Core.lua b/Core.lua index a2ea45c..9da059a 100644 --- a/Core.lua +++ b/Core.lua @@ -39,6 +39,7 @@ debug_verbose = false do function Di(...) if debug_info then + local arg = {...} for k, v in pairs(arg) do arg[k] = tostring(v) end local s = table.concat(arg, ", ") s = string.gsub(s, "([=:]),", "%1") @@ -48,6 +49,7 @@ do end function Dv(...) if debug_verbose then + local arg = {...} for k, v in pairs(arg) do arg[k] = tostring(v) end local s = table.concat(arg, ", ") s = string.gsub(s, "([=:]),", "%1") diff --git a/README-CoA.md b/README-CoA.md new file mode 100644 index 0000000..6279906 --- /dev/null +++ b/README-CoA.md @@ -0,0 +1,62 @@ +CoA VanillaGuide +================ + +This is the CoA Guild 'Exiles' fork of [VanillaGuide][upstream] by +mrmr (rsheep@gmail.com), imported from the 1.04.2 release archive +dated 2015-03-29. Upstream is unmaintained since 2015. + +[upstream]: https://github.com/rsheep/VanillaGuide + +The original addon targets Vanilla 1.12.1 (`Interface: 11200`). This +fork ports it to the Ascension 3.3.5 / Voljin client +(`Interface: 30300`) so it can be loaded alongside the rest of the +CoA addon set. + +What we patched +--------------- + +**1. Interface bump.** `VanillaGuide.toc` now declares +`Interface: 30300` and adds a `-coa1` suffix on the version line, matching +the convention of the other `coa-*` forks (see e.g. coa-bartender). + +**2. Lua 5.0 → 5.1 vararg fix.** WoW 1.12 ships Lua 5.0, which exposes +varargs as an implicit `arg` table. WoW 3.3.5 ships Lua 5.1, where +that table is gone — varargs are `{...}` or `select()`. The two debug +print helpers in `Core.lua` (`Di`, `Dv`) used the 5.0 form and would +have thrown `attempt to index global 'arg' (a nil value)` on every +debug call. Local-shadow `arg = {...}` keeps the rest of each function +unchanged. + +What is still TODO +------------------ + +- **In-game smoke test.** The addon has not yet been loaded against + the Ascension client. Expect further small breakage (frame APIs, + `GetAddOnInfo` signature, possibly map-zone coords) once we drive it + through `/vguide`. +- **MetaMapBWP integration.** MetaMap doesn't exist on 3.3.5. The + hooks in `Settings.lua` and `Frame_SettingsFrame.lua` are gated + behind `IsAddOnLoaded("MetaMap")` so they're effectively dead, but + we'll want to retarget them at **pfQuest** (already in the CoA addon + set) for waypoints and quest markers. +- **Dynamic-level-scaling content.** Ascension scales every starting + zone to the player, so all six vanilla starting zones are viable + end-to-end. Joana's faction-locked H/A split still applies (quest + givers are still faction-restricted), but the early-game chain + doesn't have to funnel through the "correct" 1-12 zone first. We + keep the H/A split and lean into the picker to show all three + per-faction starting zones up front. +- **CoA-custom content slot.** No CoA-specific zones or events are + wired in yet. Once the port is verified, we add a separate + `GuideTables/CoA/` directory for guild content (Heroes of Ascension + events, mutated-class side notes, etc.) so upstream patches can + still merge cleanly into the Joana / Brian Kopps trees. + +Files we touched +---------------- + +- `VanillaGuide.toc` — Interface bump, CoA metadata. +- `Core.lua` — local-shadow `arg = {...}` inside `Di` and `Dv`. +- `README-CoA.md` — this file. + +Everything else is the unmodified 1.04.2 import. diff --git a/VanillaGuide.toc b/VanillaGuide.toc index af03cfd..92414ea 100644 --- a/VanillaGuide.toc +++ b/VanillaGuide.toc @@ -1,17 +1,17 @@ -## Interface: 11200 -## Title: VanillaGuide |cff7fff7f -Ace2-|r -## Notes: Step-by-Step 1to60 Guides, in an Ace2 addon. +## Interface: 30300 +## Title: VanillaGuide |cff7fff7f -Ace2-|r |cffff7f7f(CoA)|r +## Notes: Step-by-Step 1-60 Guides (CoA fork: Ascension 3.3.5 port, Joana H/A paths) ## Author: mrmr -## Version: 1.04.2 +## Version: 1.04.2-coa1 ## DefaultState: enabled ## LoadOnDemand: 0 -## X-Credits: Joana/Mancow and Brian Kopps for the guides. myself for the Joana's guide and the addon itself. Kira and Cdlp for the Brian Kopps' guide. Velenran for Profession guides. +## X-Credits: Joana/Mancow and Brian Kopps for the guides. mrmr for the Joana addon. Kira and Cdlp for the Brian Kopps' guide. Velenran for Profession guides. CoA Guild 'Exiles' for the 3.3.5 port. ## X-Category: Quests -## X-Date: 2013-04-04 +## X-Date: 2026-05-11 ## X-ReleaseDate: 2012-xx-xx ## X-Email: rsheep@gmail.com -## X-Website: http://vanillaguide.googlecode.com +## X-Website: https://git.sub-net.at/Exiles/coa-vanillaguide ## X-Embeds: Ace2, FuBar-Plugin-2.0, Tablet-2.0 ## OptionalDeps: Ace2, FuBar, Tablet-2.0