Enchanting fixes, reverted Crafting module to previous version that s… (#1)

* Enchanting fixes, reverted Crafting module to previous version that supports Ascension specific crafts and Vellums.

* Updated enchanting names from DB

* Added the remaining Ascension specific recipes

* Replace SpellNames2IDs.lua with UnitCastingSpellID

* Bugfix: Ascension uses exact quality QueryAuctionItems, TSM was designed for quality or higher

* Bugfix: Properly get list of Professions via index

* Replaced factionrealm with realm
Ascension does not have strict faction seperation

* GetTradeSkillCooldown -> SpellHasBaseCooldown
GetTradeSkillCooldown only tells you if a spell is on CD, not if it has a CD
Data is from DB, which isn't populated fully yet.

* Implement backported API GetSpellBaseCooldown

* bugfix: hasCD is nil if no cd, not 0

TradeSkillMaster_Warehousing/Modules/data.lua

@@ -39,7 +39,7 @@ function data:getEmptyRestoreGroup(container, isGuildBank)
 		grp[i] = q * -1 -- convert to negative number for TSMAPI:MoveItems
 		restore[i] = q -- for the restore bagstate
 	end
-	TSM.db.factionrealm.BagState = restore
+	TSM.db.realm.BagState = restore
 	return grp
 end
 

TradeSkillMaster_Warehousing/Modules/move.lua

@@ -46,7 +46,7 @@ function move:EmptyRestore(dest, restore)
 	end
 
 	if restore then
-		moveItems = TSM.db.factionrealm.BagState
+		moveItems = TSM.db.realm.BagState
 	else
 		local srcTable = move:getContainerTable("bags")
 		moveItems = TSM.data:getEmptyRestoreGroup(srcTable, isGuildBank)
@@ -58,7 +58,7 @@ function move:EmptyRestore(dest, restore)
 		TSM:Print(L["Preparing to Move"])
 		TSMAPI:MoveItems(moveItems, TSM.PrintMsg, true)
 		if restore then
-			TSM.db.factionrealm.BagState = {}
+			TSM.db.realm.BagState = {}
 		end
 	end
 end

TradeSkillMaster_Warehousing/TradeSkillMaster_Warehousing.lua

@@ -26,7 +26,7 @@ local savedDBDefaults = {
 	},
 
 	-- data that is stored per realm/faction combination
-	factionrealm = {
+	realm = {
 		BagState = {},
 	},
 
@@ -51,9 +51,9 @@ function TSM:OnEnable()
 	-- register the module with TSM
 	TSM:RegisterModule()
 
-	if TSM.db.factionrealm.WarehousingGroups then -- remove old 1.x data on first load of 2.0
-		for key in pairs(TSM.db.factionrealm) do
-			TSM.db.factionrealm[key] = nil
+	if TSM.db.realm.WarehousingGroups then -- remove old 1.x data on first load of 2.0
+		for key in pairs(TSM.db.realm) do
+			TSM.db.realm[key] = nil
 		end
 	end
 
@@ -107,7 +107,7 @@ TSM.operationDefaults = {
 	stackSize = 5,
 	stackSizeEnabled = nil,
 	ignorePlayer = {},
-	ignoreFactionrealm = {},
+	ignorerealm = {},
 	relationships = {},
 }
 
@@ -178,8 +178,8 @@ function TSM:IsOperationIgnored(operationName)
 	TSMAPI:UpdateOperation("Warehousing", operationName)
 	local operation = TSM.operations[operationName]
 	if not operation then return end
-	local playerKey = UnitName("player").." - "..TSM.db.keys.factionrealm
-	return operation.ignorePlayer[playerKey] or operation.ignoreFactionrealm[TSM.db.keys.factionrealm]
+	local playerKey = UnitName("player").." - "..TSM.db.keys.realm
+	return operation.ignorePlayer[playerKey] or operation.ignorerealm[TSM.db.keys.realm]
 end
 
 function TSM:toggleBankUI()