fix(PORTING): correct CLEU section — CoA uses WotLK 8-arg, not modern hideCaster/RaidFlags

This commit is contained in:
2026-05-29 19:36:42 +02:00
parent 5ac82e0134
commit 8242c3ff76
+14 -7
View File
@@ -63,18 +63,25 @@ instead.
Resolve class inside `OnEnable` / event handler, not as a file-level Resolve class inside `OnEnable` / event handler, not as a file-level
`local`. `local`.
### CLEU argument positions changed ### CLEU uses the standard WotLK 8-arg signature
Verify against the 3.3.5 signature: CoA 3.3.5 fires `COMBAT_LOG_EVENT_UNFILTERED` with the plain WotLK layout —
**no** `hideCaster`, **no** `sourceRaidFlags`/`destRaidFlags` (those are
Cataclysm+):
``` ```
(event, timestamp, subevent, hideCaster, (event, timestamp, subevent,
srcGUID, srcName, srcFlags, srcRaidFlags, srcGUID, srcName, srcFlags,
destGUID, destName, destFlags, destRaidFlags, destGUID, destName, destFlags,
spellId, spellName, spellSchool, …) spellId, spellName, spellSchool, …)
``` ```
`destFlags` is arg 11, not arg 9. Many retail-era addons get this `destFlags` is **arg 9**, not arg 11. Do NOT insert the modern
wrong. `hideCaster`/RaidFlags params — doing so shifts everything right, so a
GUID slot receives a flags *number* and `destGUID:sub(...)` blows up.
This bit us once: the modern layout was wrongly applied to coa-dbm
(`UNIT_DIED` crash) and coa-quartz and had to be reverted. If an upstream
addon's handler reads `(event, ts, subevent, hideCaster, …)`, change it
back to the 8-arg form for CoA.
## Ace3 specifics ## Ace3 specifics