From febf9dd34f4a794e2e4c7e43ed3245263313d0f9 Mon Sep 17 00:00:00 2001
From: Tercio <Tercio@localhost>
Date: Fri, 27 Apr 2018 13:31:55 -0300
Subject: [PATCH] - Fixed major issue with the statistics sharing. - Added a
 new to disable score messages by using /run Details.deny_score_messages =
 true; - minor fix in the framework to stop a warning in the beta of BfA.

---
 Libs/DF/cooltip.xml |  4 ++--
 boot.lua            |  2 +-
 core/gears.lua      | 43 ++++++++++++++++++++++++++++++++++++++++---
 core/network.lua    |  6 +++---
 4 files changed, 46 insertions(+), 9 deletions(-)

diff --git a/Libs/DF/cooltip.xml b/Libs/DF/cooltip.xml
index d9723670..1505f98b 100644
--- a/Libs/DF/cooltip.xml
+++ b/Libs/DF/cooltip.xml
@@ -101,7 +101,7 @@
 				</Texture>
 				
 				<!-- banner image -->
-				<Texture name="$parent_UpperImage2" hidden="true" parentKey="upperImage2" file = "">
+				<Texture name="$parent_UpperImage2" hidden="true" parentKey="upperImage2">
 					<Anchors>
 						<Anchor point="CENTER" relativeTo="$parent" relativePoint="CENTER" x="0" y="-3"/>
 						<Anchor point="BOTTOM" relativeTo="$parent" relativePoint="TOP" x="0" y="-3"/>
@@ -111,7 +111,7 @@
 			
 			<Layer level="OVERLAY">
 				<!-- upper image2 -->
-				<Texture name="$parent_UpperImage" hidden="true" parentKey="upperImage" file = "">
+				<Texture name="$parent_UpperImage" hidden="true" parentKey="upperImage">
 					<Anchors>
 						<Anchor point="CENTER" relativeTo="$parent" relativePoint="CENTER" x="0" y="-3"/>
 						<Anchor point="BOTTOM" relativeTo="$parent" relativePoint="TOP" x="0" y="-3"/>
diff --git a/boot.lua b/boot.lua
index ce57d2ca..919b0e08 100644
--- a/boot.lua
+++ b/boot.lua
@@ -3,7 +3,7 @@
 
 		_ = nil
 		_detalhes = LibStub("AceAddon-3.0"):NewAddon("_detalhes", "AceTimer-3.0", "AceComm-3.0", "AceSerializer-3.0", "NickTag-1.0")
-		_detalhes.build_counter = 5559
+		_detalhes.build_counter = 5572
 		_detalhes.userversion = "v7.3.5." .. _detalhes.build_counter
 		_detalhes.realversion = 130 --core version
 		_detalhes.version = _detalhes.userversion .. " (core " .. _detalhes.realversion .. ")"
diff --git a/core/gears.lua b/core/gears.lua
index 6703f577..811b1f01 100644
--- a/core/gears.lua
+++ b/core/gears.lua
@@ -1009,6 +1009,11 @@ end
 --remote call RoS
 function _detalhes.storage:GetIDsToGuildSync()
 	local db = _detalhes.storage:OpenRaidStorage()
+	
+	if (db) then
+		return
+	end
+	
 	local IDs = {}
 	
 	--build the encounter ID list
@@ -1038,6 +1043,10 @@ end
 function _detalhes.storage:CheckMissingIDsToGuildSync (IDsList)
 	local db = _detalhes.storage:OpenRaidStorage()
 	
+	if (db) then
+		return
+	end
+	
 	if (type (IDsList) ~= "table") then
 		if (_detalhes.debug) then
 			_detalhes:Msg ("(debug) [RoS-EncounterSync] RoC IDsList isn't a table.")
@@ -1072,6 +1081,10 @@ end
 function _detalhes.storage:BuildEncounterDataToGuildSync (IDsList)
 	local db = _detalhes.storage:OpenRaidStorage()
 	
+	if (db) then
+		return
+	end
+	
 	if (type (IDsList) ~= "table") then
 		if (_detalhes.debug) then
 			_detalhes:Msg ("(debug) [RoS-EncounterSync] IDsList isn't a table.")
@@ -1132,6 +1145,10 @@ end
 function _detalhes.storage:AddGuildSyncData (data, source)
 	local db = _detalhes.storage:OpenRaidStorage()
 	
+	if (db) then
+		return
+	end
+	
 	local AddedAmount = 0
 	_detalhes.LastGuildSyncReceived = GetTime()
 	
@@ -1189,6 +1206,11 @@ end
 
 function _detalhes.storage:ListDiffs()
 	local db = _detalhes.storage:OpenRaidStorage()
+	
+	if (db) then
+		return
+	end
+	
 	local t = {}
 	for diff, _ in pairs (db) do
 		tinsert (t, diff)
@@ -1199,6 +1221,10 @@ end
 function _detalhes.storage:ListEncounters (diff)
 	local db = _detalhes.storage:OpenRaidStorage()
 	
+	if (db) then
+		return
+	end
+	
 	local t = {}
 	if (diff) then
 		local table = db [diff]
@@ -1221,6 +1247,10 @@ end
 function _detalhes.storage:GetPlayerData (diff, encounter_id, playername)
 	local db = _detalhes.storage:OpenRaidStorage()
 
+	if (db) then
+		return
+	end
+	
 	local t = {}
 	assert (type (playername) == "string", "PlayerName must be a string.")
 
@@ -1576,9 +1606,13 @@ function _detalhes:StoreEncounter (combat)
 			end
 			
 			if (myBestDps > d_one) then
-				print (Loc ["STRING_DETAILS1"] .. format (Loc ["STRING_SCORE_NOTBEST"], _detalhes:ToK2 (d_one), _detalhes:ToK2 (myBestDps), onencounter.date, mybest[2]))
+				if (not _detalhes.deny_score_messages) then
+					print (Loc ["STRING_DETAILS1"] .. format (Loc ["STRING_SCORE_NOTBEST"], _detalhes:ToK2 (d_one), _detalhes:ToK2 (myBestDps), onencounter.date, mybest[2]))
+				end
 			else
-				print (Loc ["STRING_DETAILS1"] .. format (Loc ["STRING_SCORE_BEST"], _detalhes:ToK2 (d_one)))
+				if (not _detalhes.deny_score_messages) then
+					print (Loc ["STRING_DETAILS1"] .. format (Loc ["STRING_SCORE_BEST"], _detalhes:ToK2 (d_one)))
+				end
 			end
 		end
 		
@@ -1594,7 +1628,10 @@ function _detalhes:StoreEncounter (combat)
 				local func = {_detalhes.OpenRaidHistoryWindow, _detalhes, raid_name, encounter_id, diff, my_role, guildName} --, 2, UnitName ("player")
 				--local icon = {[[Interface\AddOns\Details\images\icons]], 16, 16, false, 434/512, 466/512, 243/512, 273/512}
 				local icon = {[[Interface\PvPRankBadges\PvPRank08]], 16, 16, false, 0, 1, 0, 1}
-				instance:InstanceAlert (Loc ["STRING_GUILDDAMAGERANK_WINDOWALERT"], icon, _detalhes.update_warning_timeout, func, true)
+				
+				if (not _detalhes.deny_score_messages) then
+					instance:InstanceAlert (Loc ["STRING_GUILDDAMAGERANK_WINDOWALERT"], icon, _detalhes.update_warning_timeout, func, true)
+				end
 			end
 		end
 	else
diff --git a/core/network.lua b/core/network.lua
index 737200a7..eeff8e7b 100644
--- a/core/network.lua
+++ b/core/network.lua
@@ -296,7 +296,7 @@
 			
 			local IDs = _detalhes.storage:GetIDsToGuildSync()
 			
-			if (IDs [1]) then
+			if (IDs and IDs [1]) then
 				local from = UnitName ("player")
 				local realm = GetRealmName()
 				_detalhes:SendCommMessage (CONST_DETAILS_PREFIX, _detalhes:Serialize (CONST_GUILD_SYNC, from, realm, _detalhes.realversion, "L", IDs), "WHISPER", chr_name)
@@ -308,7 +308,7 @@
 		elseif (type == "L") then --RoC - the player received the IDs list and send back which IDs he doesn't have
 			local MissingIDs = _detalhes.storage:CheckMissingIDsToGuildSync (data)
 			
-			if (MissingIDs [1]) then
+			if (MissingIDs and MissingIDs [1]) then
 				local from = UnitName ("player")
 				local realm = GetRealmName()
 				_detalhes:SendCommMessage (CONST_DETAILS_PREFIX, _detalhes:Serialize (CONST_GUILD_SYNC, from, realm, _detalhes.realversion, "G", MissingIDs), "WHISPER", chr_name)
@@ -318,7 +318,7 @@
 		elseif (type == "G") then --RoS - the 'server' send the encounter dps table to the player which requested
 			local EncounterData = _detalhes.storage:BuildEncounterDataToGuildSync (data)
 			
-			if (EncounterData [1]) then
+			if (EncounterData and EncounterData [1]) then
 				local task = C_Timer.NewTicker (4, function (task)
 					task.TickID = task.TickID + 1
 					local data = task.EncounterData [task.TickID]