From d0ccba9e031379065cb85c7026c2b72dc1ccfbf0 Mon Sep 17 00:00:00 2001 From: Tercio Jose Date: Fri, 10 Mar 2023 19:47:45 -0300 Subject: [PATCH] Mythic+ Clean Up: Removed deprecated option for "Overall Segment Boss Only" --- frames/window_options2_sections.lua | 10 ---------- functions/mythicdungeon.lua | 5 ----- functions/profiles.lua | 2 -- 3 files changed, 17 deletions(-) diff --git a/frames/window_options2_sections.lua b/frames/window_options2_sections.lua index c23bc137..7a7e3dde 100644 --- a/frames/window_options2_sections.lua +++ b/frames/window_options2_sections.lua @@ -6936,16 +6936,6 @@ do desc = "When the run is done, make an overall segment.", }, - {--overall only with bosses - type = "toggle", - get = function() return Details.mythic_plus.make_overall_boss_only end, - set = function(self, fixedparam, value) - Details.mythic_plus.make_overall_boss_only = value - end, - name = "Overall Segment Boss Only", - desc = "Only add boss segments on the overall.", - }, - {--merge trash type = "toggle", get = function() return Details.mythic_plus.merge_boss_trash end, diff --git a/functions/mythicdungeon.lua b/functions/mythicdungeon.lua index efc3a8d0..682f91bc 100644 --- a/functions/mythicdungeon.lua +++ b/functions/mythicdungeon.lua @@ -76,11 +76,6 @@ function DetailsMythicPlusFrame.MergeSegmentsOnEnd() local thisCombat = segmentHistory[i] if (thisCombat and thisCombat.is_mythic_dungeon_run_id == Details.mythic_dungeon_id) then local canAddThisSegment = true - if (_detalhes.mythic_plus.make_overall_boss_only) then - if (not thisCombat.is_boss) then - canAddThisSegment = false - end - end if (canAddThisSegment) then newCombat = newCombat + thisCombat diff --git a/functions/profiles.lua b/functions/profiles.lua index 2268f233..fa684630 100644 --- a/functions/profiles.lua +++ b/functions/profiles.lua @@ -1497,7 +1497,6 @@ local default_global_data = { --merge_boss_with_trash = false, --this won't be used boss_dedicated_segment = true, -- make_overall_when_done = true, -- - make_overall_boss_only = false, -- show_damage_graphic = true, delay_to_show_graphic = 5, last_mythicrun_chart = {}, @@ -1895,7 +1894,6 @@ function Details:ImportProfile (profileString, newProfileName, bImportAutoRunCod mythicPlusSettings.delete_trash_after_merge = true mythicPlusSettings.boss_dedicated_segment = true mythicPlusSettings.make_overall_when_done = true - mythicPlusSettings.make_overall_boss_only = false mythicPlusSettings.show_damage_graphic = true mythicPlusSettings.delay_to_show_graphic = 5 mythicPlusSettings.last_mythicrun_chart = {}