Fixed "Time out of combat" after mythic+ and another round of polishing frames and menus

This commit is contained in:
Tercio Jose
2024-03-06 14:50:56 -03:00
parent 9c23a8a8af
commit b7e6b89792
14 changed files with 133 additions and 95 deletions
-10
View File
@@ -250,16 +250,6 @@ function mythicDungeonCharts:OnEndMythicDungeon()
return
end
mythicDungeonCharts:Debug("Dungeon ended successfully, chart data capture stopped, scheduling to open the window.")
C_Timer.After(0.1, function()
end)
--the run is valid, schedule to open the chart window
Details.mythic_plus.delay_to_show_graphic = 1
C_Timer.After(Details.mythic_plus.delay_to_show_graphic, mythicDungeonFrames.ShowEndOfMythicPlusPanel)
if (verbosemode) then
mythicDungeonCharts:Debug("OnEndMythicDungeon() success!")
end
+7 -1
View File
@@ -18,6 +18,7 @@ Details.MythicPlus = {
RunID = 0,
}
local mythicDungeonFrames = Details222.MythicPlus.Frames
local mythicDungeonCharts = Details:CreateEventListener()
Details222.MythicPlus.Charts.Listener = mythicDungeonCharts
@@ -60,6 +61,7 @@ function DetailsMythicPlusFrame.BossDefeated(this_is_end_end, encounterID, encou
Details:UpdateState_CurrentMythicDungeonRun(true, Details.MythicPlus.SegmentID, Details.MythicPlus.PreviousBossKilledAt)
end
--this function is called 2 seconds after the event COMBAT_MYTHICDUNGEON_END
function DetailsMythicPlusFrame.MythicDungeonFinished(fromZoneLeft)
if (DetailsMythicPlusFrame.IsDoingMythicDungeon) then
if (DetailsMythicPlusFrame.DevelopmentDebug) then
@@ -107,6 +109,10 @@ function DetailsMythicPlusFrame.MythicDungeonFinished(fromZoneLeft)
Details.MythicPlus.IsRestoredState = nil
--the run is valid, schedule to open the chart window
Details.mythic_plus.delay_to_show_graphic = 1
C_Timer.After(Details.mythic_plus.delay_to_show_graphic, mythicDungeonFrames.ShowEndOfMythicPlusPanel)
--shutdown parser for a few seconds to avoid opening new segments after the run ends
if (not fromZoneLeft) then
Details:CaptureSet(false, "damage", false, 15)
@@ -351,7 +357,7 @@ DetailsMythicPlusFrame:SetScript("OnEvent", function(_, event, ...)
Details222.MythicPlus.LogStep("ZONE_CHANGED_NEW_AREA | player has left the dungeon and Details! finished the dungeon because of that.")
--send mythic dungeon end event
Details:SendEvent("COMBAT_MYTHICDUNGEON_END")
Details:SendEvent("COMBAT_MYTHICDUNGEON_END") --on leave dungeon
--finish the segment
DetailsMythicPlusFrame.BossDefeated(true)
+2 -2
View File
@@ -1617,7 +1617,7 @@ local default_global_data = {
reverse_death_log = false,
delay_to_show_graphic = 10,
delay_to_show_graphic = 1,
last_mythicrun_chart = {},
mythicrun_chart_frame = {},
mythicrun_chart_frame_minimized = {},
@@ -2025,7 +2025,7 @@ function Details:ImportProfile (profileString, newProfileName, bImportAutoRunCod
mythicPlusSettings.make_overall_boss_only = false
mythicPlusSettings.show_damage_graphic = true
mythicPlusSettings.reverse_death_log = false
mythicPlusSettings.delay_to_show_graphic = 10
mythicPlusSettings.delay_to_show_graphic = 1
mythicPlusSettings.last_mythicrun_chart = {}
mythicPlusSettings.mythicrun_chart_frame = {}
mythicPlusSettings.mythicrun_chart_frame_minimized = {}