Fixed "Time out of combat" after mythic+ and another round of polishing frames and menus

frames/window_breakdown/window_playerbreakdown.lua

@@ -263,8 +263,13 @@ Details.PlayerBreakdown.RoundedCornerPreset = {
 	color = {.1, .1, .1, 0.834},
 }
 
+function Details:RefreshWindowColor()
+	local colorTable = Details.frame_background_color
+	Details:SetWindowColor(unpack(colorTable))
+end
+
 function Details:SetWindowColor(r, g, b, a)
-	--SetColor implemented by rounded corners, does not save the color, by apply
+	--SetColor implemented by rounded corners
 	breakdownWindowFrame:SetColor(r, g, b, a)
 	breakdownSideMenu:SetColor(r, g, b, a)
 
@@ -277,6 +282,14 @@ function Details:SetWindowColor(r, g, b, a)
 		DetailsReportWindow:SetColor(r, g, b, a)
 	end
 
+	if (DetailsAllAttributesFrame) then
+		DetailsAllAttributesFrame:SetColor(r, g, b, a)
+	end
+
+	if (DetailsSpellBreakdownOptionsPanel) then
+		DetailsSpellBreakdownOptionsPanel:SetColor(r, g, b, a)
+	end
+
 	local colorTable = Details.frame_background_color
 	colorTable[1] = r
 	colorTable[2] = g

frames/window_breakdown/window_playerbreakdown_list.lua

@@ -525,12 +525,6 @@ local createSegmentsScrollBox = function(breakdownWindowFrame, breakdownSideMenu
 		end
 	end
 
-	--get a Details! window
-	local lowerInstanceId = Details:GetLowerInstanceNumber()
-	local fontFile
-	local fontSize
-	local fontOutline
-
 	--header setup
 	local headerTable = {
 		{text = "Segment Name", width = 100},
@@ -539,15 +533,6 @@ local createSegmentsScrollBox = function(breakdownWindowFrame, breakdownSideMenu
 		padding = 2,
 	}
 
-	if (lowerInstanceId) then
-		local instance = Details:GetInstance(lowerInstanceId)
-		if (instance) then
-			fontFile = instance.row_info.font_face
-			fontSize = instance.row_info.font_size
-			fontOutline = instance.row_info.textL_outline
-		end
-	end
-
 	local createSegmentLine = function(self, index)
 		--create a new line
 		local line = CreateFrame("button", "$parentLine" .. index, self, "BackdropTemplate")

frames/window_breakdown/window_playerbreakdown_spells_options.lua

@@ -23,10 +23,17 @@ local createOptionsPanel = function()
     local optionsFrame = DF:CreateSimplePanel(UIParent, 550, 500, "Details! Breakdown Options", "DetailsSpellBreakdownOptionsPanel")
     optionsFrame:SetFrameStrata("DIALOG")
     optionsFrame:SetPoint("topleft", UIParent, "topleft", 2, -40)
+    optionsFrame.Title:SetParent(optionsFrame)
+    optionsFrame.TitleBar:Hide()
     optionsFrame:Show()
 
-    local bUseSolidColor = true
-    DF:ApplyStandardBackdrop(optionsFrame, bUseSolidColor)
+    --remove the backdrop
+    optionsFrame:SetBackdrop(nil)
+
+    --apply rounded corners with the breakdown window preset
+    DF:AddRoundedCornersToFrame(optionsFrame, Details.PlayerBreakdown.RoundedCornerPreset)
+
+    Details:RefreshWindowColor()
 
     local resetSettings = function()
         --overwrite the settings for the spell frame
@@ -222,6 +229,7 @@ local createOptionsPanel = function()
                     colorTable[3] = b
                     colorTable[4] = a
                     Details:UpdateBreakdownPlayerList()
+                    DetailsAllAttributesFrame:UpdateFontStrings()
                 end,
                 name = "Text Color",
                 desc = "Text Color",
@@ -233,6 +241,7 @@ local createOptionsPanel = function()
                 set = function(self, fixedparam, value)
                     Details.breakdown_general.font_size = value
                     Details:UpdateBreakdownPlayerList()
+                    DetailsAllAttributesFrame:UpdateFontStrings()
                 end,
                 min = 8,
                 max = 20,
@@ -247,6 +256,7 @@ local createOptionsPanel = function()
                 set = function(self, fixedparam, value)
                     Details.breakdown_general.font_outline = value
                     Details:UpdateBreakdownPlayerList()
+                    DetailsAllAttributesFrame:UpdateFontStrings()
                 end,
                 name = "Text Outline",
                 desc = "Text Outline",
@@ -258,6 +268,7 @@ local createOptionsPanel = function()
                 set = function(self, fixedparam, value)
                     Details.breakdown_general.font_face = value
                     Details:UpdateBreakdownPlayerList()
+                    DetailsAllAttributesFrame:UpdateFontStrings()
                 end,
                 name = "Font Face",
                 desc = "Font Face",