General Changes ad Improvements
- Added: Details:IsInMythicPlus() return true if the player is on a mythic dungeon run. - CombatObjects now have the key 'is_challenge' if the combat is a part of a challenge mode or mythic+ run. - Evoker extra bar tooltip's, now also show the uptime of Black Attunement and Prescience applications. - Breakdown Window now show Plater Npc Colors in the target box. - Added event: "COMBAT_MYTHICPLUS_OVERALL_READY", trigger when the overall segment for the mythic+ is ready. - Added event: "COMBAT_PLAYER_LEAVING", trigger at the beginning of the leave combat process. - Library updates: Details! Framework and Lib Open Raid.
This commit is contained in:
+32
-5
@@ -1457,8 +1457,22 @@ detailsFramework.CastFrameFunctions = {
|
||||
end
|
||||
end,
|
||||
|
||||
UpdateCastingInfo = function(self, unit)
|
||||
local name, text, texture, startTime, endTime, isTradeSkill, castID, notInterruptible, spellID = CastInfo.UnitCastingInfo(unit)
|
||||
UpdateCastingInfo = function(self, unit, ...)
|
||||
local unitID, castID, spellID = ...
|
||||
local name, text, texture, startTime, endTime, isTradeSkill, uciCastID, notInterruptible, uciSpellID = CastInfo.UnitCastingInfo(unit)
|
||||
spellID = uciSpellID or spellID
|
||||
castID = uciCastID or castID
|
||||
|
||||
if spellID and (not name or not texture or not text) then
|
||||
local siName, _, siIcon, siCastTime = GetSpellInfo(spellID)
|
||||
texture = texture or siIcon
|
||||
name = name or siName
|
||||
text = text or siName
|
||||
if not startTime then
|
||||
startTime = GetTime()
|
||||
endTime = startTime + siCastTime
|
||||
end
|
||||
end
|
||||
|
||||
--is valid?
|
||||
if (not self:IsValid(unit, name, isTradeSkill, true)) then
|
||||
@@ -1519,8 +1533,8 @@ detailsFramework.CastFrameFunctions = {
|
||||
self:UpdateInterruptState()
|
||||
end,
|
||||
|
||||
UNIT_SPELLCAST_START = function(self, unit)
|
||||
self:UpdateCastingInfo(unit)
|
||||
UNIT_SPELLCAST_START = function(self, unit, ...)
|
||||
self:UpdateCastingInfo(unit, ...)
|
||||
self:RunHooksForWidget("OnCastStart", self, self.unit, "UNIT_SPELLCAST_START")
|
||||
end,
|
||||
|
||||
@@ -1570,7 +1584,20 @@ detailsFramework.CastFrameFunctions = {
|
||||
|
||||
UpdateChannelInfo = function(self, unit, ...)
|
||||
local unitID, castID, spellID = ...
|
||||
local name, text, texture, startTime, endTime, isTradeSkill, notInterruptible, spellID, _, numStages = CastInfo.UnitChannelInfo (unit)
|
||||
local name, text, texture, startTime, endTime, isTradeSkill, notInterruptible, uciSpellID, _, numStages = CastInfo.UnitChannelInfo (unit)
|
||||
spellID = uciSpellID or spellID
|
||||
castID = uciCastID or castID
|
||||
|
||||
if spellID and (not name or not texture or not text) then
|
||||
local siName, _, siIcon, siCastTime = GetSpellInfo(spellID)
|
||||
texture = texture or siIcon
|
||||
name = name or siName
|
||||
text = text or siName
|
||||
if not startTime then
|
||||
startTime = GetTime()
|
||||
endTime = startTime + siCastTime
|
||||
end
|
||||
end
|
||||
|
||||
--is valid?
|
||||
if (not self:IsValid (unit, name, isTradeSkill, true)) then
|
||||
|
||||
Reference in New Issue
Block a user