From 95096af849dac9ac12775bdd9b0b04cef887221c Mon Sep 17 00:00:00 2001
From: Tercio Jose <terciob19@hotmail.com>
Date: Mon, 19 Aug 2024 13:19:05 -0300
Subject: [PATCH] Fixed Streamer plugin bug

---
 boot.lua                                      |  4 ++--
 plugins/Details_Compare2/Details_Compare2.lua | 13 +++++++++----
 plugins/Details_Streamer/Details_Streamer.lua |  2 ++
 3 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/boot.lua b/boot.lua
index b6c4e2d3..648fd8ce 100644
--- a/boot.lua
+++ b/boot.lua
@@ -19,8 +19,8 @@
 		local addonName, Details222 = ...
 		local version = GetBuildInfo()
 
-		Details.build_counter = 12877
-		Details.alpha_build_counter = 12877 --if this is higher than the regular counter, use it instead
+		Details.build_counter = 12879
+		Details.alpha_build_counter = 12879 --if this is higher than the regular counter, use it instead
 		Details.dont_open_news = true
 		Details.game_version = version
 		Details.userversion = version .. " " .. Details.build_counter
diff --git a/plugins/Details_Compare2/Details_Compare2.lua b/plugins/Details_Compare2/Details_Compare2.lua
index 5d7268cb..7d7eb661 100644
--- a/plugins/Details_Compare2/Details_Compare2.lua
+++ b/plugins/Details_Compare2/Details_Compare2.lua
@@ -1,11 +1,16 @@
 
 do
+	local _
 	local Details = Details
+
 	if (not Details) then
 		print("Details! Not Found.")
 		return
 	end
 
+	---@type detailsframework
+	local detailsFramework = DetailsFramework
+
 	local CONST_COMPARETYPE_SPEC = 1
 	local CONST_COMPARETYPE_SEGMENT = 2
 
@@ -125,9 +130,6 @@ do
 	--> create a plugin object
 	local compareTwo = Details:NewPluginObject("Details_Compare2", _G.DETAILSPLUGIN_ALWAYSENABLED)
 
-	---@type detailsframework
-	local detailsFramework = DetailsFramework
-
 	--> set the description
 	compareTwo:SetPluginDescription("Replaces the default comparison window on the player breakdown.")
 
@@ -1902,12 +1904,15 @@ do
 				newComparisonFrame.titleIcon = detailsFramework:CreateTexture(newComparisonFrame)
 				newComparisonFrame.titleIcon:SetPoint("topleft", newComparisonFrame, "topleft", 0, comparisonFrameSettings.playerNameYOffset)
 
-				--player name shown above the scrolls
+				--player name or segment name shown above the scrolls
 				---@type df_label
 				newComparisonFrame.titleLabel = detailsFramework:CreateLabel(newComparisonFrame, "")
 				newComparisonFrame.titleLabel:SetPoint("left", newComparisonFrame.titleIcon, "right", 2, 0)
 				newComparisonFrame.titleLabel.fontsize = comparisonFrameSettings.playerNameSize
 
+				--combat selector dropdown
+				--todo: create a dropdown to select the combat
+
 				--grandient texture above the comparison frame
 				local gradientTitle = detailsFramework:CreateTexture(newComparisonFrame, {gradient = "vertical", fromColor = {0, 0, 0, 0.25}, toColor = "transparent"}, 1, 16, "artwork", {0, 1, 0, 1})
 				gradientTitle:SetPoint("bottomleft", newComparisonFrame, "topleft", 0, 0)
diff --git a/plugins/Details_Streamer/Details_Streamer.lua b/plugins/Details_Streamer/Details_Streamer.lua
index 64e5c35b..f3abfa5c 100644
--- a/plugins/Details_Streamer/Details_Streamer.lua
+++ b/plugins/Details_Streamer/Details_Streamer.lua
@@ -63,6 +63,8 @@ local iconSize = 16
 --default icon for an attack on a monster
 local defaultAttackIcon = [[Interface\CURSOR\UnableAttack]]
 
+local GetSpellInfo = GetSpellInfo
+
 local function CreatePluginFrames()
 	--shortcut for details fade function
 	local fader = Details.FadeHandler.Fader