Fixing stuff from latest alpha and more development

frames/window_currentdps.lua

@@ -583,8 +583,8 @@ function Details:CreateCurrentDpsFrame(parent, name)
 				DF:SetFontOutline (labelYellowTeam_DPS, Details.realtime_dps_meter.font_shadow)
 
 				--wipe current data for arena
-				Details:Destroy (f.PlayerTeamBuffer)
-				Details:Destroy (f.YellowTeamBuffer)
+				Details:Destroy(f.PlayerTeamBuffer)
+				Details:Destroy(f.YellowTeamBuffer)
 
 				--reset damage
 				f.PlayerTeamDamage = 0
@@ -902,9 +902,9 @@ function Details:CreateCurrentDpsFrame(parent, name)
 		
 		function eventListener:ResetBuffer()
 			if (f:IsShown()) then
-				Details:Destroy (f.PlayerTeamBuffer)
-				Details:Destroy (f.YellowTeamBuffer)
-				Details:Destroy (f.GroupBuffer)
+				Details:Destroy(f.PlayerTeamBuffer)
+				Details:Destroy(f.YellowTeamBuffer)
+				Details:Destroy(f.GroupBuffer)
 				f.GroupTotalDamage = 0
 				f.PlayerTeamDamage = 0
 				f.YellowDamage = 0

frames/window_forge.lua

@@ -105,10 +105,10 @@ function Details:OpenForge()
         f:SetScript("OnHide", function()
             for _, module in ipairs(all_modules) do
                 if (module.data) then
-                    Details:Destroy (module.data)
+                    Details:Destroy(module.data)
                 end
             end
-            Details:Destroy (spell_already_added)
+            Details:Destroy(spell_already_added)
         end)
         
         f.bg1 = f:CreateTexture(nil, "background")
@@ -438,7 +438,7 @@ function Details:OpenForge()
                 local filter_name = DetailsForgeAllSpellsNameFilter:GetText()
                 local lower_FilterCaster = lower (filter_caster)
                 local lower_FilterSpellName = lower (filter_name)
-                Details:Destroy (spell_already_added)
+                Details:Destroy(spell_already_added)
 
                 local SpellPoll = Details.spell_pool
                 for spellID, className in pairs(SpellPoll) do
@@ -582,7 +582,7 @@ function Details:OpenForge()
                 local lower_FilterSpellName = lower (filter_name)
                 local lower_FilterEncounterName = lower (filter_encounter)
                 
-                Details:Destroy (spell_already_added)
+                Details:Destroy(spell_already_added)
                 
                 local SpellPoll = Details.encounter_spell_pool
                 for spellID, spellTable in pairs(SpellPoll) do

frames/window_main.lua

@@ -2302,7 +2302,7 @@ function icon_frame_events:EnterCombat()
 		anim.icon_frame.icon_animation = nil
 		anim.icon_frame = nil
 	end
-	Details:Destroy (Details.icon_animations.load.in_use)
+	Details:Destroy(Details.icon_animations.load.in_use)
 end
 
 icon_frame_events:RegisterEvent("COMBAT_PLAYER_ENTER", "EnterCombat")
@@ -3060,7 +3060,7 @@ function Details:InstanceAlert (msg, icon, timeInSeconds, clickfunc, doflash, fo
 	end
 
 	self.alert.button.func = nil
-	Details:Destroy (self.alert.button.func_param)
+	Details:Destroy(self.alert.button.func_param)
 
 	if (clickfunc) then
 		self.alert.button.func = clickfunc[1]
@@ -5654,17 +5654,17 @@ function Details:SetIconAlpha(alpha, hide, noAnimations)
 	end
 end
 
-function Details:ToolbarMenuSetButtonsOptions(spacement, shadow)
+function Details:ToolbarMenuSetButtonsOptions(spacement, iconShadows)
 	if (type(spacement) ~= "number") then
 		spacement = self.menu_icons.space
 	end
 
-	if (type(shadow) ~= "boolean") then
-		shadow = self.menu_icons.shadow
+	if (type(iconShadows) ~= "boolean") then
+		iconShadows = self.menu_icons.shadow
 	end
 
 	self.menu_icons.space = spacement
-	self.menu_icons.shadow = shadow
+	self.menu_icons.shadow = iconShadows
 
 	return self:ToolbarMenuSetButtons()
 end
@@ -6339,7 +6339,7 @@ local buildSegmentTooltip = function(self, deltaTime)
 		for i = Details.segments_amount, 1, -1 do
 			if (i <= fill) then
 				local thisCombat = Details.tabela_historico.tabelas[i]
-				if (thisCombat) then
+				if (thisCombat and not thisCombat.__destroyed) then
 					local enemy = thisCombat.is_boss and thisCombat.is_boss.name
 					local segmentInfoAdded = false
 					segmentsUsed = segmentsUsed + 1
@@ -6622,7 +6622,7 @@ local buildSegmentTooltip = function(self, deltaTime)
 
 					if (not segmentInfoAdded) then
 						gameCooltip:AddLine(Loc["STRING_SEGMENT_ENEMY"] .. ":", enemy, 2, "white", "white")
-						local decorrido = thisCombat:GetCombatTime()
+						local decorrido = thisCombat:GetCombatTime() --attempt to call method 'GetCombatTime' (a nil value)
 						local minutos, segundos = floor(decorrido/60), floor(decorrido%60)
 						gameCooltip:AddLine(Loc["STRING_SEGMENTS_LIST_COMBATTIME"] .. ":", minutos.."m "..segundos.."s", 2, "white", "white")
 
@@ -6632,11 +6632,16 @@ local buildSegmentTooltip = function(self, deltaTime)
 
 					amountOfSegments = amountOfSegments + 1
 				else
-					gameCooltip:AddLine(Loc["STRING_SEGMENT_LOWER"] .. " #" .. i, _, 1, "gray")
-					gameCooltip:AddMenu(1, instance.TrocaTabela, i)
-					gameCooltip:AddIcon([[Interface\QUESTFRAME\UI-Quest-BulletPoint]], "main", "left", 16, 16, nil, nil, nil, nil, empty_segment_color)
-					gameCooltip:AddLine(Loc["STRING_SEGMENT_EMPTY"], _, 2)
-					gameCooltip:AddIcon([[Interface\CHARACTERFRAME\Disconnect-Icon]], 2, 1, 12, 12, 0.3125, 0.65625, 0.265625, 0.671875)
+					if (thisCombat and thisCombat.__destroyed) then
+						Details:Msg("a deleted combat object was found on the history table, please report this bug on discord:")
+						Details:Msg("combat destroyed by:", thisCombat.__destroyedBy)
+					else
+						gameCooltip:AddLine(Loc["STRING_SEGMENT_LOWER"] .. " #" .. i, _, 1, "gray")
+						gameCooltip:AddMenu(1, instance.TrocaTabela, i)
+						gameCooltip:AddIcon([[Interface\QUESTFRAME\UI-Quest-BulletPoint]], "main", "left", 16, 16, nil, nil, nil, nil, empty_segment_color)
+						gameCooltip:AddLine(Loc["STRING_SEGMENT_EMPTY"], _, 2)
+						gameCooltip:AddIcon([[Interface\CHARACTERFRAME\Disconnect-Icon]], 2, 1, 12, 12, 0.3125, 0.65625, 0.265625, 0.671875)
+					end
 				end
 
 				if (menuIndex) then

frames/window_playerbreakdown_avoidance.lua

@@ -383,10 +383,11 @@
         local avoidance_fill = function(tab, player, combat)
             local elapsed_time = combat:GetCombatTime()
 
-            local last_combat = combat.previous_combat
+            local last_combat = combat.previous_combat --this is always nil from 2023 may 26
             if (not last_combat or not last_combat [1]) then
                 last_combat = combat
             end
+            
             local last_actor = last_combat (1, player.nome)
             local n = player.nome
             if (n:find("-")) then

frames/window_wa.lua

@@ -1961,7 +1961,7 @@ function _detalhes:OpenAuraPanel (spellid, spellname, spellicon, encounterid, tr
         spellname = select(1, GetSpellInfo(spellid))
     end
 
-    Details:Destroy (empty_other_values)
+    Details:Destroy(empty_other_values)
     other_values = other_values or empty_other_values
     
     if (not DetailsAuraPanel or not DetailsAuraPanel.Initialized) then