From 54075b1883196f4597c716582c4d6faedc8cfdc4 Mon Sep 17 00:00:00 2001 From: Tercio Jose Date: Sat, 6 May 2023 16:18:09 -0300 Subject: [PATCH] disabled warning classic era msg --- frames/window_playerbreakdown_spells.lua | 10 +++++++--- startup.lua | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/frames/window_playerbreakdown_spells.lua b/frames/window_playerbreakdown_spells.lua index b1fbb68b..ac3174ef 100644 --- a/frames/window_playerbreakdown_spells.lua +++ b/frames/window_playerbreakdown_spells.lua @@ -1915,7 +1915,6 @@ function spellsTab.CreateSpellScrollContainer(tabFrame) --~scroll ~create ~spell ---@type height local height = Details.breakdown_spell_tab.spellcontainer_height - --create a container for the scrollframe local options = { width = Details.breakdown_spell_tab.spellcontainer_width, height = Details.breakdown_spell_tab.spellcontainer_height, @@ -1927,12 +1926,14 @@ function spellsTab.CreateSpellScrollContainer(tabFrame) --~scroll ~create ~spell } + ---create a container for the scrollframe ---@type df_framecontainer local container = DF:CreateFrameContainer(tabFrame, options, tabFrame:GetName() .. "SpellScrollContainer") container:SetPoint("topleft", tabFrame, "topleft", 5, -5) container:SetFrameLevel(tabFrame:GetFrameLevel() + 10) spellsTab.SpellContainerFrame = container + --when a setting is changed in the container, it will call this function, it is registered below with SetSettingChangedCallback() local settingChangedCallbackFunction = function(frameContainer, settingName, settingValue) --doing here the callback for thge settings changed in the container if (frameContainer:IsShown()) then if (settingName == "height") then @@ -1951,9 +1952,11 @@ function spellsTab.CreateSpellScrollContainer(tabFrame) --~scroll ~create ~spell spellsTab.GetSpellBlockContainer():SendSettingChangedCallback("UpdateSize", -1) end end - local defaultAmountOfLines = 50 container:SetSettingChangedCallback(settingChangedCallbackFunction) + --amount of lines which will be created for the scrollframe + local defaultAmountOfLines = 50 + --replace this with a framework scrollframe ---@type breakdownspellscrollframe local scrollFrame = DF:CreateScrollBox(container, "$parentSpellScroll", refreshFunc, {}, width, height, defaultAmountOfLines, CONST_SPELLSCROLL_LINEHEIGHT) @@ -1983,13 +1986,14 @@ function spellsTab.CreateSpellScrollContainer(tabFrame) --~scroll ~create ~spell local headerTable = {} + ---create the header frame, the header frame is the frame which shows the columns names to describe the data shown in the scrollframe ---@type df_headerframe local header = DetailsFramework:CreateHeader(container, headerTable, headerOptions) scrollFrame.Header = header scrollFrame.Header:SetPoint("topleft", scrollFrame, "topleft", 0, 1) scrollFrame.Header:SetColumnSettingChangedCallback(onHeaderColumnOptionChanged) - --cache the type of this container + --cache the containerType which this header is used for headerContainerType[scrollFrame.Header] = "spells" --create the scroll lines diff --git a/startup.lua b/startup.lua index 3e805cf4..d8bed550 100644 --- a/startup.lua +++ b/startup.lua @@ -535,7 +535,7 @@ function Details:StartMeUp() if (not DetailsFramework.IsClassicWow()) then --i'm not in classc wow else - print("|CFFFFFF00[Details!]: you're using Details! for RETAIL on Classic WOW, please get the classic version (Details! Damage Meter Classic WoW), if you need help see our Discord (/details discord).") + --print("|CFFFFFF00[Details!]: you're using Details! for RETAIL on Classic WOW, please get the classic version (Details! Damage Meter Classic WoW), if you need help see our Discord (/details discord).") end Details:InstallHook("HOOK_DEATH", Details.Coach.Client.SendMyDeath)