Commit Graph

8 Commits

Author SHA1 Message Date
florian.berthold b8154b3fec fix(Sun Cleric): wire Sanctify into DC.SpellsToUse, bump Asc-1.1.3-coa
The previous commit registered COA_SANCTIFY in customSpells but didn't
add an entry to DC.SpellsToUse, which is what actually routes a class
to its dispel. Without that, Decursive knows the spell exists but
doesn't know it cleanses Magic/Disease/Poison — Sun Clerics couldn't
click-dispel anything. Adds the routing entry with IsBest=1.

Also bumps the .toc version: Asc-1.1.2-coa → Asc-1.1.3-coa.
2026-05-24 23:35:21 +02:00
florian.berthold c6e168dfe0 Revert "coa: sanitize debuff icon path before SetTexture"
This reverts commit 8ac1651db0.
2026-05-20 10:13:38 +02:00
florian.berthold 8ac1651db0 coa: sanitize debuff icon path before SetTexture
Ascension has been shipping auras whose UnitAura()-returned icon path
is nil or unresolvable on the local client. Decursive's LiveList fed
it straight into Texture:SetTexture(), and on the 3.3.5 engine that
crashes the renderer downstream — #132 ACCESS_VIOLATION near
Ascension.exe text + null+offset (texture-loader struct left
half-initialized). Confirmed across multiple recent DLL hashes
(0baf62b, 6a3088c, 7bba9c8, 502ca3c), recurring fault @ 0x00749EEB.

Fix: when Debuff.Texture isn't a non-empty string, fall back to
INV_Misc_QuestionMark and log the offender once (via AddDebugText so
it lands in Logs/Trace.txt) for future identification of the bad aura.

Bumped toc to Asc-1.1.3-coa.
2026-05-20 00:34:21 +02:00
florian.berthold 3869a067c6 coa: extend default-realm spell IDs to CustomClass branch
CoA characters were crashing on load with table-index-is-nil at
Dcr_opt.lua:292 (DebuffsToIgnore[DS["Phase Shift"]]), then cascading
into self.db being nil at DCR_init.lua:724 and ScanTime nil arithmetic
at Dcr_LiveList.lua:389.

Root cause: D:GetSpellsTranslations populates DC.DS by iterating the
class-specific Spells table. The IsCustomClass branch added in
32324ff only filled COA_* dispel spells, but Dcr_opt.lua DebuffsToIgnore
/ BuffDebuff and DCR_init.lua SpellsToUse reference DS["Phase Shift"]
/ "SPELL_CURE_POISON" / etc. unconditionally - keys that only existed
in the heroSpells / defaultSpells branches.

Merged the IsDefaultClass and IsCustomClass branches so both share the
same defaultSpells base table; the CoA-specific dispels remain a
nested IsCustomClass-gated extension. CoA realm shares world content
with the default realm so the prefixed IDs apply; _LOST SPELL_ fallback
in GetSpellsTranslations handles any that don't resolve.
2026-05-10 22:15:18 +02:00
florian.berthold 26abb6d513 coa: dynamic PopulateListFrame buttons for 21 CoA custom classes
Closes the deferred UI piece from 32324ff. The 11 vanilla class buttons
in Dcr_lists.xml stay hardcoded so this fork keeps working on stock
clients with no CoA extras (DC.ClassNumToUName produces 0 entries at
idx >= 22 there, builder returns early).

D:BuildPopulateExtraClassButtons(frame) walks DC.ClassNumToUName for
keys 22+, sorted, and creates one GameMenuButtonTemplate per class:
  - First extra fills row 6's empty right column (beside Hero)
  - Remaining alternate left/right, chained off Hero / Deathknight
  - Frame grows by ceil((n-1)/2) * 20 px so the existing BOTTOM-anchored
    Close button slides down with it
Idempotent via frame.coa_extras_built.

Wired from DecursivePopulateListFrame OnShow with a Dcr.BuildPopulateExtraClassButtons
nil-guard so an out-of-order load doesn't break the frame.

Bumped toc to Asc-1.1.1-coa.
2026-05-10 22:06:53 +02:00
florian.berthold 32324ff732 coa: register dispel spells for 21 CoA custom classes
Three gaps closed for CoA custom-class players:

1. DCR_init.lua C_Player:IsCustomClass() branches were stubs printing
   "CoA is not currently supported". Filled both branches (SpellsToUse +
   Spells dictionary) with 11 dispel spell IDs covering 10 CoA classes
   (Chronomancer, Cultist, Templar, Venomancer, Pyromancer, Ranger,
   Bloodmage, Runemaster, Starcaller, Witch Hunter). The other 11 CoA
   classes have no dedicated player-cast dispel in coa-db.

2. Dcr_Raid.lua ClassNumTo{LName,UName} were hardcoded to indices
   11..21 (vanilla 10 + HERO). Append every additional CLASS_SORT_ORDER
   token starting at 22 — append-only so existing DecursiveDB skip /
   priority numeric keys stay valid. CoA-class units in raids now get
   priority/skip lookups instead of silent nil-guarded no-ops.

3. Bumped toc Version to Asc-1.1.0-coa.

Spell IDs sourced from coa-db (mind_of_ascension_talent + class_spell)
filtered to effect_id=38 (DISPEL) with misc_value in {1,2,3,4} (Magic,
Curse, Disease, Poison).

PopulateListFrame XML buttons (Dcr_lists.xml) for the 21 CoA classes
deferred — needs UI rework (frame is already near-full at 11 buttons).
Skip/priority lists still work without these populate-by-class
shortcuts.
2026-05-10 05:31:59 +02:00
Jeremy P 8d647691b8 Added OG9 spell IDs and removed old disable check code (#4)
* Added OG9 spell ids

* minor formatting

* removed old "disable" code for some players original author didn't like

* ascension version change

* missed a call to chjeckplayer
2025-11-09 10:38:34 -07:00
Andrew6810 6988cc52f5 init 2022-10-21 06:52:48 -07:00