From f305f0a2266c4abad975d2db03acf103b0c0397b Mon Sep 17 00:00:00 2001 From: Florian Berthold Date: Fri, 29 May 2026 19:34:25 +0200 Subject: [PATCH] coa.15: guard GetRestedXP + GetMoneyString/GetTimeString against no-value getters GetRestedXP did 'rate * coeff' on a nil DS:GetRestXPRate result (crashed Account Summary). Guarded it, plus defensive nil->0 on the two common string helpers. --- Altoholic/Altoholic.lua | 4 +++- Altoholic/Altoholic.toc | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Altoholic/Altoholic.lua b/Altoholic/Altoholic.lua index 8aee6ce..1babc6d 100644 --- a/Altoholic/Altoholic.lua +++ b/Altoholic/Altoholic.lua @@ -552,6 +552,7 @@ function addon:GetSpellIDFromRecipeLink(link) end function addon:GetMoneyString(copper, color, noTexture) + copper = copper or 0 -- CoA: callers may pass a no-value DS getter result color = color or "|cFFFFD700" local gold = floor( copper / 10000 ); @@ -572,6 +573,7 @@ function addon:GetMoneyString(copper, color, noTexture) end function addon:GetTimeString(seconds) + seconds = seconds or 0 -- CoA: callers may pass a no-value DS getter result local days = floor(seconds / 86400); -- TotalTime is expressed in seconds seconds = mod(seconds, 86400) local hours = floor(seconds / 3600); @@ -648,7 +650,7 @@ function Altoholic:FormatDelay(timeStamp) end function addon:GetRestedXP(character) - local rate = DS:GetRestXPRate(character) + local rate = DS:GetRestXPRate(character) or 0 -- CoA: getter returns no value for unscanned/partial chars local coeff = 1 if addon.Options:Get("RestXPMode") == 1 then diff --git a/Altoholic/Altoholic.toc b/Altoholic/Altoholic.toc index 7a82ff0..4ab39a4 100644 --- a/Altoholic/Altoholic.toc +++ b/Altoholic/Altoholic.toc @@ -13,7 +13,7 @@ ## Author: Thaoky, Telkar-RG ## X-Edited-By: Exiles (Sub-Net) — florian.berthold@sub-net.at -## Version: 3.3.002b-coa.14 +## Version: 3.3.002b-coa.15 ## X-Category: Inventory, Tradeskill, Mail ## X-Localizations: enUS, frFR, zhCN, zhTW, deDE, koKR, esES, esMX, ruRU ## X-Website: http://wow.curse.com/downloads/wow-addons/details/altoholic.aspx